Migrate parts of rustc_expand to session diagnostics#104460
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 10, 2022
Merged
Migrate parts of rustc_expand to session diagnostics#104460bors merged 1 commit intorust-lang:masterfrom
rustc_expand to session diagnostics#104460bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @estebank (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-translation
Collaborator
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
Noratrieb
force-pushed
the
expand-the-translation
branch
2 times, most recently
from
a93ff0f to
fc9a5a2
Compare
This comment has been minimized.
This comment has been minimized.
klensy
reviewed
Nov 19, 2022
Noratrieb
force-pushed
the
expand-the-translation
branch
from
fc9a5a2 to
9ad80d4
Compare
This comment has been minimized.
This comment has been minimized.
Noratrieb
force-pushed
the
expand-the-translation
branch
from
9ad80d4 to
2f2212c
Compare
Collaborator
|
☔ The latest upstream changes (presumably #104696) made this pull request unmergeable. Please resolve the merge conflicts. |
Noratrieb
force-pushed
the
expand-the-translation
branch
from
2f2212c to
664b903
Compare
davidtwco
reviewed
Nov 23, 2022
Member
davidtwco
left a comment
davidtwco
left a comment
There was a problem hiding this comment.
Apologies for the delay in reviewing, this largely looks good to me, left a few comments.
Noratrieb
force-pushed
the
expand-the-translation
branch
from
664b903 to
f7d1bba
Compare
Member
Author
|
Some of your suggested impls were already present and some had to be added. |
This comment has been minimized.
This comment has been minimized.
Noratrieb
force-pushed
the
expand-the-translation
branch
from
f7d1bba to
830b7ec
Compare
Collaborator
|
☔ The latest upstream changes (presumably #105425) made this pull request unmergeable. Please resolve the merge conflicts. |
davidtwco
approved these changes
Dec 8, 2022
Member
davidtwco
left a comment
davidtwco
left a comment
There was a problem hiding this comment.
Apologies for the delay in getting back to this, r=me after rebasing
This migrates everything but the `mbe` and `proc_macro` modules. It also contains a few cleanups and drive-by/accidental diagnostic improvements which can be seen in the diff for the UI tests.
Noratrieb
force-pushed
the
expand-the-translation
branch
from
830b7ec to
2f9f097
Compare
Member
Author
|
@bors r=davidtwco |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 10, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#104460 (Migrate parts of `rustc_expand` to session diagnostics) - rust-lang#105192 (Point at LHS on binop type err if relevant) - rust-lang#105234 (Remove unneeded field from `SwitchTargets`) - rust-lang#105239 (Avoid heap allocation when truncating thread names) - rust-lang#105410 (Consider `parent_count` for const param defaults) - rust-lang#105482 (Fix invalid codegen during debuginfo lowering) Failed merges: - rust-lang#105411 (Introduce `with_forced_trimmed_paths`) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migrates everything but the
mbeandproc_macromodules. It also contains a few cleanups and drive-by/accidental diagnostic improvements which can be seen in the diff for the UI tests.