Skip to content

get rid of to_poly_trait_predicate and many without_const calls#104586

Closed
oli-obk wants to merge 2 commits intorust-lang:masterfrom
oli-obk:santa-clauses-make-goals
Closed

get rid of to_poly_trait_predicate and many without_const calls#104586
oli-obk wants to merge 2 commits intorust-lang:masterfrom
oli-obk:santa-clauses-make-goals

Conversation

@oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Nov 18, 2022

continuation of #104483

r? @compiler-errors

@rustbot
Copy link
Collaborator

rustbot commented Nov 18, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @compiler-errors (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 18, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 18, 2022

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@jackh726
Copy link
Member

jackh726 commented Nov 21, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 21, 2022

📌 Commit aa1045e1cbbe9007a91a96e0fa8af98a64dbd434 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2022
@bors
Copy link
Collaborator

bors commented Nov 22, 2022

☔ The latest upstream changes (presumably #104533) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 22, 2022
@oli-obk oli-obk force-pushed the santa-clauses-make-goals branch from aa1045e to 2a87fa4 Compare November 23, 2022 09:18
@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 23, 2022

@bors r=jackh726

@bors
Copy link
Collaborator

bors commented Nov 23, 2022

📌 Commit 2a87fa402ac9377935f7073d36e13886051cf4a2 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 23, 2022
@oli-obk oli-obk force-pushed the santa-clauses-make-goals branch from 2a87fa4 to b19cf14 Compare November 23, 2022 09:22
@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 23, 2022

@bors r=jackh726

@bors
Copy link
Collaborator

bors commented Nov 23, 2022

📌 Commit b19cf14 has been approved by jackh726

It is now in the queue for this repository.

Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 23, 2022
@Manishearth
Rollup merge of rust-lang#104586 - oli-obk:santa-clauses-make-goals, …
6b7fa4e 
…r=jackh726

get rid of to_poly_trait_predicate and many `without_const` calls

continuation of rust-lang#104483

r? `@compiler-errors`
@Manishearth Manishearth mentioned this pull request Nov 23, 2022
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 23, 2022
@Manishearth
Rollup merge of rust-lang#104586 - oli-obk:santa-clauses-make-goals, …
36ceaff 
…r=jackh726

get rid of to_poly_trait_predicate and many `without_const` calls

continuation of rust-lang#104483

r? ``@compiler-errors``
@Manishearth Manishearth mentioned this pull request Nov 23, 2022
Closed
@bors
Copy link
Collaborator

bors commented Nov 24, 2022

☔ The latest upstream changes (presumably #104809) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 24, 2022
@oli-obk oli-obk force-pushed the santa-clauses-make-goals branch from b19cf14 to b1ee716 Compare November 24, 2022 14:08
@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 24, 2022

@bors r=jackh726

@bors
Copy link
Collaborator

bors commented Nov 24, 2022

📌 Commit b1ee7167b29ae1bf85831ed4fa86087f2c76d939 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 24, 2022
@bors
Copy link
Collaborator

bors commented Nov 25, 2022

☔ The latest upstream changes (presumably #104845) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 25, 2022
@oli-obk oli-obk force-pushed the santa-clauses-make-goals branch from b1ee716 to 300a3a4 Compare November 25, 2022 09:47
@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 25, 2022

@bors r=jackh726

@bors
Copy link
Collaborator

bors commented Nov 25, 2022

📌 Commit b1ee7167b29ae1bf85831ed4fa86087f2c76d939 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 25, 2022
@bors
Copy link
Collaborator

bors commented Nov 25, 2022

☔ The latest upstream changes (presumably #104846) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 25, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 25, 2022

This landed as part of #104846

@oli-obk oli-obk closed this Nov 25, 2022
@oli-obk oli-obk deleted the santa-clauses-make-goals branch November 25, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@compiler-errors compiler-errors

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@oli-obk @rustbot @jackh726 @bors @compiler-errors