Merged
Conversation
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
Introduce `with_forced_trimmed_paths` Built on top of rust-lang#104922, only last commit is relevant.
… r=JohnTitor Document behaviour of `--remap-path-prefix` with several matches
…1-dead compiler: remove unnecessary imports and qualified paths Some of these imports were necessary before Edition 2021, others were already in the prelude. I hope it's fine that this PR is so spread-out across files :/
…ines-non-rust, r=notriddle rustdoc: Only hide lines starting with `#` in rust code blocks Fixes rust-lang#105527. So before approving, this is a big question: in rust code blocks, in a line starts with a `#`, we hide it in the output. However, should we do the same for non-rust code blocks too? I think it's a bit problematic to do it because `#` can be used for many things but I prefer to check first with everyone (might also be worth updating documentation too). cc ``@rust-lang/rustdoc`` r? ``@notriddle``
…errors Add some regression tests for rust-lang#44454 Closes rust-lang#44454 r? ``@compiler-errors`` Signed-off-by: Yuki Okushi <jtitor@2k36.org>
…-errors Add regression test for rust-lang#104582 Closes rust-lang#104582 r? `@compiler-errors` Signed-off-by: Yuki Okushi <jtitor@2k36.org>
rustbot
added
A-query-system
Member
Author
|
@bors r+ rollup=never p=6 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: previous master: b3ddfeb5a8 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Dec 11, 2022
Collaborator
|
Finished benchmarking commit (f34356e): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
with_forced_trimmed_paths#105411 (Introducewith_forced_trimmed_paths)--remap-path-prefixwith several matches #105532 (Document behaviour of--remap-path-prefixwith several matches)#in rust code blocks #105539 (rustdoc: Only hide lines starting with#in rust code blocks )Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup