rustc_session: remove dead code from check_expected_reuse()

[matthiaskrgr]

looks like we construct this IncorrectCguReuseType but actually never do anything with it. So by skipping that, we can actually remove half the function which is a bit weird... 😅

[rustbot]

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

[compiler-errors]

This is an error that was created but not emitted in #100753. This needs to be wrapped in a sess.emit_err(IncorrectCguReuseType { ... }).

[compiler-errors]

It's a shame that no UI test actually pointed at this change, but this also looks like an internal error so I'm unsurprised.

[cjgillot]

Thanks @matthiaskrgr. Could you try and make a test for it? There are already cgu-reuse tests in src/test/incremental.
@bors r+

[bors]

📌 Commit c3415d4 has been approved by cjgillot

It is now in the queue for this repository.

[bors]

⌛ Testing commit c3415d4 with merge 97e767941d3332218a4be60f64d907c7574344e9...

[bors]

💔 Test failed - checks-actions

[rust-log-analyzer]

The job x86_64-gnu-llvm-13-stage1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Some tests failed in compiletest suite=incremental mode=incremental host=x86_64-unknown-linux-gnu target=x86_64-unknown-linux-gnu

---- [incremental] src/test/incremental/thinlto/cgu_keeps_identical_fn.rs stdout ----

error in revision `cfail2`: test compilation failed although it shouldn't!
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/bin/rustc" "/checkout/src/test/incremental/thinlto/cgu_keeps_identical_fn.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "cfail2" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/thinlto/cgu_keeps_identical_fn/cgu_keeps_identical_fn.inc" "-Z" "incremental-verify-ich" "-O" "--error-format" "json" "--json" "future-incompat" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/thinlto/cgu_keeps_identical_fn" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/thinlto/cgu_keeps_identical_fn/auxiliary" "-Z" "query-dep-graph" "-O"
stdout: none
--- stderr -------------------------------
error: CGU-reuse for `cgu_keeps_identical_fn-foo` is `PostLto ` but should be `No`
   |
   |
LL | #![rustc_expected_cgu_reuse(module = "cgu_keeps_identical_fn-foo", cfg = "cfail2", kind = "no")]

error: aborting due to previous error
------------------------------------------

[ehuss]

@bors r-

bors resync doesn't track failures

[JohnCSimon]

@matthiaskrgr Ping from triage: Can you post your status on this PR? This has sat idle for a few months.

[Dylan-DPC]

Closing this as inactive. Feel free to reöpen this pr or create a new pr if you get the time to work on this. Thanks