Merged
Conversation
- Remove setup special-casing in Flags::parse
I really liked this structure that dtolney brought up in rust-lang#105316, so wanted to put it in the docs to help others use it.
This removes another python search from bootstrap.
… r=jyn514 Fix `x setup -h -v` should work r? `@jyn514` I have to convert profile to path and back in order to remove special-casing in bootstrap. I also check for `dry_run` so that `config.toml` and/ or `.git/hooks/pre-push` will not be created if `--dry-run` is specified. Please help me see if this is ok, thanks alot!
…obDegen Remove dead code after destination propagation Fixes rust-lang#105428. cc `@JakobDegen`
Make the x tool use the x and x.ps1 scripts This removes another python search from bootstrap. r? `@jyn514`
…rrors remove redundant clone
…r=the8472 Another `as_chunks` example I really liked this structure that dtolney brought up in rust-lang#105316, so wanted to put it in the docs to help others use it.
avoid .into() conversion to identical types
…erence, r=oli-obk don't destuct references just to reborrow
rustbot
added
T-bootstrap
Member
Author
|
@bors r+ rollup=never p=7 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: previous master: 37efc81072 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (d0dc9ef): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
x setup -h -vshould work #96584 (Fixx setup -h -vshould work)as_chunksexample #105858 (Anotheras_chunksexample)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup