Merged
Conversation
This reverts commit d9a1faa. This was originally part of a larger PR that has now been closed as a different approach is taken now.
Add tests for rust-lang#41731 Closes rust-lang#41731
…rochenkov Add a test for rust-lang#103095 closes rust-lang#103095
…etrochenkov print argument name in arg mismatch if possible A bit more contextual than just `/* value */`, at least when the argument is named something related to its context. The UI test cases are... not super convincing, but also they're minimized tests.
…est, r=notriddle Update browser-ui-test version to reduce GUI tests flakyness Part of rust-lang#93784. r? `@notriddle`
…-errors remove redundant fn params that were only "used" in recursion
…iler-errors don't clone Copy types
use &str / String literals instead of format!()
Revert "Introduce lowering_arena to avoid creating AST nodes on the fly" This reverts commit d9a1faa (rust-lang#101499). This was originally part of rust-lang#101345 which has now been closed as a different approach is taken now. r? `@oli-obk` cc `@spastorino`
Member
Author
|
@bors r+ rollup=never p=8 |
Collaborator
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: previous master: 2b094b1ede In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Dec 19, 2022
Collaborator
|
Finished benchmarking commit (a474ebb): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup