Remove u8 slice output of simd_bitmask#105990
Remove u8 slice output of simd_bitmask#105990oli-obk wants to merge 1 commit intorust-lang:masterfrom
simd_bitmask#105990Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. Please see the contribution instructions for more information. |
|
It is not entirely useless. It is necessary for vectors with more than 128 lanes as we don't have integer types with more than 128bits. |
O_o that's a thing? Yea... I guess LLVM can actually generate these types. Does such a vector exist right now? |
|
You can define it yourself using |
|
This is used by bits of std::simd that haven't made it upstream yet (blocked on some const generics features): https://github.com/rust-lang/portable-simd/blob/master/crates/core_simd/src/masks/full_masks.rs#L162. There are already instruction sets with more than 128 lanes (Arm SVE, RISC-V V extension). |
We definitely intend to support more than 128-lane |
|
that said, when we finally get generic-sized integer types ( |
related: rust-lang/miri#2734
this seems to be unused and trivially replaced by https://doc.rust-lang.org/std/primitive.i64.html#method.to_be_bytes or similar
r? @Amanieu @matthiaskrgr