Use verbose suggestions for mutability errors

[estebank]

No description provided.

[rustbot]

r? @eholk

(rustbot has picked a reviewer for you, use r? to override)

[eholk]

@bors r+

[estebank]

@bors r=eholk

[bors]

📌 Commit b9439eb has been approved by eholk

It is now in the queue for this repository.

[Xiretza]

This could've benefited from a split into two commits: one to update the variable interpolations in format!() calls (no functional change), and another to change the actual diagnostic verbosity and update tests. Probably not a big enough issue to still do it now though.

[bors]

⌛ Testing commit b9439eb with merge e060a2386699edf9a12c4c392c96fa113a49a8db...

[jyn514]

@bors r- r+ tree closed in #106232 (comment)

[bors]

📌 Commit b9439eb has been approved by jyn514

It is now in the queue for this repository.

[bors]

🌲 The tree is currently closed for pull requests below priority 500. This pull request will be tested once the tree is reopened.

[rust-log-analyzer]

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Checking which error codes lack tests...
Found 507 error codes
Found 0 error(s) in error codes
Done!
thread '<unnamed>' panicked at 'Encountered error while testing Git status: "failed to execute git log command: fatal: ambiguous argument ':!src/tools/miri': unknown revision or path not in the working tree.\nUse '--' to separate paths from revisions, like this:\n'git <command> [<revision>...] -- [<file>...]'\n"', src/tools/tidy/src/no_merge.rs:23:25
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Any { .. }', src/tools/tidy/src/main.rs:42:61
* 393 features
Build completed unsuccessfully in 0:00:26

[bors]

⌛ Testing commit b9439eb with merge 96c1f33...

[bors]

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing 96c1f33 to master...

[rust-timer]

Finished benchmarking commit (96c1f33): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.3%	[1.1%, 1.6%]	3
Improvements ✅ (primary)	-2.6%	[-2.7%, -2.6%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.6%	[-2.7%, -2.6%]	2

Cycles

This benchmark run did not return any relevant results for this metric.