Skip possible where_clause_object_safety lints when checking multiple_supertrait_upcastable

[nbdd0121]

Fix #106247

To achieve this, I lifted the WhereClauseReferencesSelf out from object_safety_violations and move it into is_object_safe (which is changed to a new query).

cc @dtolnay
r? @compiler-errors

[bors]

☔ The latest upstream changes (presumably #106324) made this pull request unmergeable. Please resolve the merge conflicts.

[compiler-errors]

This needs a rebase just to add the lint back. I think the changes look fine, maybe is_object_safe needs to be renamed so it can reflect the fact that it has side-effects ("check_is_object_safe"?)

[compiler-errors]

@rustbot author

[rustbot]

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

• Stabilizing library features
• Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
• Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
• Changing public documentation in ways that create new stability guarantees
• Changing observable runtime behavior of library APIs

[nbdd0121]

@rustbot ready

[compiler-errors]

Looks good to me!

@bors r+

[bors]

📌 Commit 66f3ab9 has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 66f3ab9 with merge d117135...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing d117135 to master...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing d117135 to master...

[rust-timer]

Finished benchmarking commit (d117135): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.6%	[1.4%, 1.8%]	2
Improvements ✅ (primary)	-2.8%	[-2.8%, -2.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.8%	[-2.8%, -2.8%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-	-	0