Rust ast lowering doc tests#106486
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nagisa (or someone else) soon. Please see the contribution instructions for more information. |
rustbot
added
S-waiting-on-review
|
r? @jyn514 |
|
work in progress for #99144 |
| /// ``` | ||
| /// | ||
| /// and return a type like `TestReturn<'static, T, 'a>`, so that the function looks like: | ||
| /// type TestReturn<'a, 'x, T> = impl Debug + 'x; |
There was a problem hiding this comment.
Instead of deleting the codeblock, you can use rust,ignore at the header to prevent rustdoc from compiling or running it. You could also use text as the header to avoid treating it as a test at all, although you would lose syntax highlighting.
There was a problem hiding this comment.
My apologies for being late on this PR; I didn't have the time.
jyn514
added
S-waiting-on-author
|
this has some overlap with #106574, unfortunately. cc @technetos, I haven't yet looked at the differences between the two. |
|
Not sure when I'll have time to look at this. r? @Nilstrieb @rustbot ready |
rustbot
added
S-waiting-on-review
| /// | ||
| /// ```rust | ||
| /// fn test<'a, T: Debug>(x: &'a T) -> TestReturn<'static, T, 'a> | ||
| /// #![feature(type_alias_impl_trait)] |
There was a problem hiding this comment.
Can you also ignore this here?
Noratrieb
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #106621) made this pull request unmergeable. Please resolve the merge conflicts. |
|
This was subsumed by #106486, closing it. Thank you for the PR anyways! |
8 participants
No description provided.