Merged
Conversation
Co-authored-by: Esteban Kuber <estebank@users.noreply.github.com>
… the correct allocator.
…lnay Don't derive Debug for `OnceWith` & `RepeatWith` Closures don't impl Debug, so the derived impl is kinda useless. The behavior of not debug-printing closures is consistent with the rest of the iterator adapters/sources.
Mention "signature" rather than "fn pointer" when impl/trait methods are incompatible Fixes rust-lang#80929 Fixes rust-lang#67296
…r=Nilstrieb Structured suggestion for `&mut dyn Iterator` when possible Fix rust-lang#37914.
…clone, r=estebank Suggest using clone when we have &T and T implemented Clone Fixes rust-lang#106443
Document that `Vec::from_raw_parts[_in]` must be given a pointer from the correct allocator. Currently, the documentation of `Vec::from_raw_parts` and `Vec::from_raw_parts_in` says nothing about what allocator the pointer must come from. This PR adds that missing information explicitly.
…y-err, r=estebank Suppress type errors that come from private fields Fixes rust-lang#57320 There was some discussion here (rust-lang#57320 (comment)), but I honestly think the second error is worth suppressing regardless. I would be open to feedback though -- perhaps we can suppress the `.len()` suggestion if there's type error (since we have access to [`Expectation`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_hir_typeck/enum.Expectation.html), we can determine that). r? ``@estebank``
…r=Mark-Simulacrum Add goml scripts to tidy checks r? ``@notriddle``
…ompiler-errors Do not emit structured suggestion for turbofish with wrong span Fix rust-lang#79161.
rustbot
added
A-testsuite
Contributor
Author
|
@bors r+ rollup=never p=5 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: previous master: a377893da2 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (2e677c0): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
OnceWith&RepeatWith#104163 (Don't derive Debug forOnceWith&RepeatWith)&mut dyn Iteratorwhen possible #106363 (Structured suggestion for&mut dyn Iteratorwhen possible)Vec::from_raw_parts[_in]must be given a pointer from the correct allocator. #106584 (Document thatVec::from_raw_parts[_in]must be given a pointer from the correct allocator.)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup