Closed
Conversation
The relevant filtering should have been performed by borrowck.
I don't have time to both review and work on my foundation grant.
Support eager subdiagnostics again See rust-lang#104941 (comment) I'm not sure how to add a test for this. But I did pick some of the diagnostic structs in the mentioned PR and it works with them.
…, r=lcnr Check `impl`'s `where` clauses in `consider_impl_candidate` in experimental solver Check impl's nested predicates as part of the recursive evaluate in `consider_impl_candidate`. <sub>Unless, for some reason, these are intentionally **not** checked here -- in which case, I really don't understand where they're being checked...<sub> r? `@lcnr`
Do not filter substs in `remap_generic_params_to_declaration_params`. The relevant filtering should have been performed by borrowck. Fixes rust-lang#105826 r? types
…=jackh726 Allow codegen to unsize `dyn*` to `dyn` `dyn* Trait` is just another type that implements `Trait`, so we should be able to unsize `&dyn* Trait` into `&dyn Trait` perfectly fine, same for `Box` and other unsizeable types. Fixes rust-lang#106488
…Titor add tests for div_duration_* functions Per rust-lang#63139 (comment) this adds unit tests for the functions that will hopefully effectively demonstrate that `div_duration` is ready to be stabilized.
std sync tests: better type name, clarifying comment Just resolving some confusion that I encountered while reading these tests. r? `@thomcc`
…rieb Fix help docs for -Zallow-features The arguments for -Zallow-features are comma-separated (`parse_opt_comma_list`), not space separated (`parse_list`).
Remove myself from rust-lang/rust reviewers I don't have time to both review and work on my foundation grant.
rustbot
added
A-meta
Member
Author
|
@bors r+ p=8 rollup=never |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 6da9f57 with merge cf5194f5293e68a8bf93385c1dc02a2a941341ad... |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
⌛ Testing commit 6da9f57 with merge 398a86e294e5f5a809b6247468105a2698f6af69... |
Member
Author
|
@bors treeclosed=50 |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Member
Author
|
@bors retry |
bors
added
S-waiting-on-bors
This was referenced Jan 10, 2023
Member
|
@JohnTitor please use a higher priority for treeclosed in the future - I accidentally set #106458 to be merged before Pietro's PR fixing CI because I didn't know there were CI issues. |
Collaborator
Collaborator
|
⌛ Testing commit 6da9f57 with merge 24b8ea813f33c301dd6aca2507e50c5c3510ab6e... |
Member
Author
bors
added
S-waiting-on-author
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
impl'swhereclauses inconsider_impl_candidatein experimental solver #106397 (Checkimpl'swhereclauses inconsider_impl_candidatein experimental solver)remap_generic_params_to_declaration_params. #106503 (Do not filter substs inremap_generic_params_to_declaration_params.)dyn*todyn#106532 (Allow codegen to unsizedyn*todyn)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup