Remove a couple of #[doc(hidden)] pub fn and their #[feature] gates#106677
Remove a couple of #[doc(hidden)] pub fn and their #[feature] gates#106677bors merged 1 commit intorust-lang:masterfrom
#[doc(hidden)] pub fn and their #[feature] gates#106677Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @scottmcm (or someone else) soon. Please see the contribution instructions for more information. |
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
22c1816 to
f6a64e9
Compare
|
☔ The latest upstream changes (presumably #107828) made this pull request unmergeable. Please resolve the merge conflicts. |
f6a64e9 to
77c85e9
Compare
| } | ||
|
|
||
| #[derive(Copy, Clone, Debug, PartialEq, Eq)] | ||
| enum CharErrorKind { |
There was a problem hiding this comment.
nit: in future, please try to keep things in a relative order such that things like this type don't show as delete-then-add in the diff.
There was a problem hiding this comment.
Sorry. Not sure why I did this.
|
Thanks! Cleaning these up to just be the Error trait method directly makes sense to me. @bors r+ rollup=iffy (should be fine, but |
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (d094016): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
No description provided.