Merged
Conversation
If cs_action != 0, we should check the ttype_index field in action record. If ttype_index == 0, a clean up action is taken.
Tracking issue: rust-lang#65815
… adjust test This reverts commit e2d41f4.
Modify the linting behavior and add the corresponding regression test
Excludes rust-lang@c34fbfa to make Git blame a bit more useful.
…iapi, r=joshtriplett Stabilize `abi_efiapi` feature Tracking issue: rust-lang#65815 Closes rust-lang#65815
[LSDA] Take ttype_index into account when taking unwind action If `cs_action != 0`, we should check the `ttype_index` field in action record. If `ttype_index == 0`, a clean up action is taken; otherwise catch action is taken. This can fix unwind failure on AIX which uses LLVM's libunwind by default. IIUC, rust's LSDA is borrowed from c++ and I'm assuming itanium-cxx-abi https://itanium-cxx-abi.github.io/cxx-abi/exceptions.pdf should be followed, so the fix follows what libcxxabi does. See https://github.com/llvm/llvm-project/blob/ec48682ce9f61d056361c5095f21e930b8365661/libcxxabi/src/cxa_personality.cpp#L152 for use of `ttype_index`.
…twco Mark ZST as FFI-safe if all its fields are PhantomData This presents one possible solution to issue: rust-lang#106629. This is my first (tentative) contribution to the compiler itself. I'm looking forward for comments and feedback Closes: rust-lang#106629
…int, r=Nilstrieb Adding a hint on iterator type errors Issue reference rust-lang#106728 - [x] add a case in the attribute - [x] add a test closes rust-lang#106728
…, r=notriddle Fix reexport of `doc(hidden)` item Part of rust-lang#59368. It doesn't fix the `doc(inline)` nor the `doc(hidden)` on macro. I'll do it in a follow-up PR. r? `@notriddle`
…jgillot Revert "Make nested RPITIT inherit the parent opaque's generics." This reverts commit e2d41f4, and adjusts the `tests/ui/async-await/in-trait/nested-rpit.rs` test. r? `@cjgillot` fixes rust-lang#106332, manually verified because it had no minimization :/ reopens rust-lang#105197 cc rust-lang#106729
…n, r=wesleywiser Re-add mw to review rotation r? `@wesleywiser`
Exclude formatting commit from blame Excludes rust-lang@c34fbfa (cc `@dtolnay)` to make Git blame a bit more useful.
rustbot
added
A-meta
Member
Author
|
@bors r+ p=8 rollup=never |
Collaborator
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: previous master: 61a415be59 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (86ad69d): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
abi_efiapifeature #105795 (Stabilizeabi_efiapifeature)doc(hidden)item #106741 (Fix reexport ofdoc(hidden)item)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup