Remove unstable Poll::ready

[ibraheemdev]

Based on the discussion in #89780, this API is problematic and would likely require changes over an edition. Now that task::ready! is stabilized, this seems unlikely to happen, so I think we should just go ahead and remove it.

ACP: rust-lang/libs-team#214

[rustbot]

r? @scottmcm

(rustbot has picked a reviewer for you, use r? to override)

[rustbot]

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

• Stabilizing library features
• Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
• Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
• Changing public documentation in ways that create new stability guarantees
• Changing observable runtime behavior of library APIs

[pitaj]

I believe this requires an ACP, so please create one (if you haven't already).
Then, link it here and mark this as awaiting ACP using: @rustbot label -S-waiting-on-author +S-waiting-on-ACP

@rustbot label +T-libs-api -T-libs +S-waiting-on-author -S-waiting-on-review

[ibraheemdev]

@rustbot label -S-waiting-on-author +S-waiting-on-ACP

[bors]

☔ The latest upstream changes (presumably #109732) made this pull request unmergeable. Please resolve the merge conflicts.

[joshtriplett]

ACP approved, r=me on the PR with the conflict removed.

[joshtriplett]

@bors delegate+

[the8472]

@bors r=joshtriplett

[bors]

📌 Commit 4fbca2e has been approved by joshtriplett

It is now in the queue for this repository.

[bors]

⌛ Testing commit 4fbca2e with merge 8a281f9...

[bors]

☀️ Test successful - checks-actions
Approved by: joshtriplett
Pushing 8a281f9 to master...

[rust-timer]

Finished benchmarking commit (8a281f9): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.1%	[1.1%, 1.1%]	1
Improvements ✅ (primary)	-4.0%	[-4.0%, -4.0%]	1
Improvements ✅ (secondary)	-1.7%	[-1.7%, -1.7%]	1
All ❌✅ (primary)	-4.0%	[-4.0%, -4.0%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.4%	[3.4%, 3.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 640.817s -> 643.295s (0.39%)