Rollup of 9 pull requests by matthiaskrgr · Pull Request #107408 · rust-lang/rust

matthiaskrgr · 2023-01-28T10:11:10Z

Successful merges:

Improve unexpected close and mismatch delimiter hint in TokenTreesReader #104012 (Improve unexpected close and mismatch delimiter hint in TokenTreesReader)
Stabilize the const_socketaddr feature #104252 (Stabilize the const_socketaddr feature)
Replace libc::{type} with crate::ffi::{type} #105524 (Replace libc::{type} with crate::ffi::{type})
Detect references to non-existant messages in Fluent resources #107096 (Detect references to non-existant messages in Fluent resources)
Add regression test for #60755 #107355 (Add regression test for Error when trying use trait alias for Fn() in impl #60755)
Remove BOOL_TY_FOR_UNIT_TESTING #107384 (Remove BOOL_TY_FOR_UNIT_TESTING)
Use FallibleTypeFolder for ConstInferUnifier not TypeRelation #107385 (Use FallibleTypeFolder for ConstInferUnifier not TypeRelation)
rustdoc: remove inline javascript from copy-path button #107391 (rustdoc: remove inline javascript from copy-path button)
Remove ControlFlow::{BREAK, CONTINUE} #107398 (Remove ControlFlow::{BREAK, CONTINUE})

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Signed-off-by: Yuki Okushi <jtitor@2k36.org>

It is not used anymore for unit testing.

Libs-API decided to remove these in rust-lang#102697. Follow-up to rust-lang#107023, which removed them from `compiler/`, but a couple new ones showed up since that was merged.

Replace libc::{type} imports with crate::ffi::{type} outside of `std::sys` and `std::os`. Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>

…indentation, r=petrochenkov Improve unexpected close and mismatch delimiter hint in TokenTreesReader Fixes rust-lang#103882 Fixes rust-lang#68987 Fixes rust-lang#69259 The inner indentation mismatching will be covered by outer block, the new added function `report_error_prone_delim_block` will find out the error prone candidates for reporting.

…r=JohnTitor Stabilize the const_socketaddr feature Stabilizes `#![feature(const_socketaddr)]`. Tracking issue: rust-lang#82485 Closes rust-lang#82485 This has been unstably const for over a year now. And the code change simplifying the constness of the `new` constructors has been in stable Rust since 1.64 (a bit over a full release cycle). I'm not aware of any blockers to this stabilization.

Replace libc::{type} with crate::ffi::{type} Replace libc::{type} imports with crate::ffi::{type} outside of `std::sys` and `std::os`. Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>

…=compiler-errors Detect references to non-existant messages in Fluent resources Should help with cases like rust-lang#107091, where `{variable}` (a message reference) is accidentally typed, rather than `{$variable}` (a variable reference) Fixes rust-lang#107370 ```@rustbot``` label +A-translation

…errors Add regression test for rust-lang#60755 Closes rust-lang#60755 r? compiler-errors Signed-off-by: Yuki Okushi <jtitor@2k36.org>

…-obk Remove `BOOL_TY_FOR_UNIT_TESTING` It is not used anymore for unit testing.

…r, r=compiler-errors Use `FallibleTypeFolder` for `ConstInferUnifier` not `TypeRelation` I am not sure why this was using a `TypeRelation`, maybe it predates the ability to have fallible type folders

…on, r=GuillaumeGomez rustdoc: remove inline javascript from copy-path button

Remove `ControlFlow::{BREAK, CONTINUE}` Libs-API decided to remove these in rust-lang#102697. Follow-up to rust-lang#107023, which removed them from `compiler/`, but a couple new ones showed up since that was merged. r? libs

matthiaskrgr · 2023-01-28T10:11:26Z

@bors r+ rollup=never p=9

bors · 2023-01-28T10:11:27Z

📌 Commit c95707a has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-01-28T13:13:03Z

⌛ Testing commit c95707a with merge bca8b4d...

bors · 2023-01-28T15:54:00Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing bca8b4d to master...

bors · 2023-01-28T15:54:01Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing bca8b4d to master...

rust-timer · 2023-01-28T15:54:07Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha

previous master: bca8b4dc32

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-01-28T15:56:33Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#107398	c1a8c485ebe37c151795ef3989ff468c0429e920
#107391	32d648122f70db57e3a7ebe2c753bbe24d8bb9fd
#107385	1856f5a55ad851556662e790b75b3a4193adaed2
#107384	133939a6ce009b804fd3612eb4265e4e8d6237e1
#107355	f1f29020d70ecf2b33a13e31c42eb0d19d9db040
#107096	a81e63097a59c6ac6413801be74f99c90a82cc79
#105524	f35e5dae7d10fc683d3a2aeeb5209c1a058dba72
#104252	319bd6bf9f0f5359f69789b5611a85b5b410b5ad
#104012	389f481b28bb369f041360c1ccef9bd02de9c3a7

previous master: d8da513668

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-01-28T18:27:25Z

Finished benchmarking commit (bca8b4d): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.8%	[1.5%, 2.1%]	6
Regressions ❌ (secondary)	0.6%	[0.2%, 1.8%]	5
Improvements ✅ (primary)	-0.6%	[-0.6%, -0.6%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.2%	[-0.6%, 2.1%]	8

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[1.8%, 3.7%]	2
Improvements ✅ (primary)	-2.3%	[-3.4%, -0.4%]	3
Improvements ✅ (secondary)	-2.1%	[-2.7%, -0.9%]	4
All ❌✅ (primary)	-2.3%	[-3.4%, -0.4%]	3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.4%	[1.4%, 1.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.4%	[1.4%, 1.4%]	1

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#104012 (Improve unexpected close and mismatch delimiter hint in TokenTreesReader) - rust-lang#104252 (Stabilize the const_socketaddr feature) - rust-lang#105524 (Replace libc::{type} with crate::ffi::{type}) - rust-lang#107096 (Detect references to non-existant messages in Fluent resources) - rust-lang#107355 (Add regression test for rust-lang#60755) - rust-lang#107384 (Remove `BOOL_TY_FOR_UNIT_TESTING`) - rust-lang#107385 (Use `FallibleTypeFolder` for `ConstInferUnifier` not `TypeRelation`) - rust-lang#107391 (rustdoc: remove inline javascript from copy-path button) - rust-lang#107398 (Remove `ControlFlow::{BREAK, CONTINUE}`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

faern and others added 22 commits January 25, 2023 22:23

Stabilize the const_socketaddr feature

50f29d4

add testcase for rust-lang#104012

c4d00d7

Improve unexpected close and mismatch delimiter hint in TokenTreesReader

cd23323

Add regression test for rust-lang#60755

dbe911f

Signed-off-by: Yuki Okushi <jtitor@2k36.org>

Detect references to non-existant messages in Fluent resources

ed707a1

Fix some Fluent typos

0ae0d87

Remove BOOL_TY_FOR_UNIT_TESTING

454c473

It is not used anymore for unit testing.

yeet

29901e0

Remove unused import

5152e84

rustdoc: remove inline javascript from copy-path button

0959149

Remove ControlFlow::{BREAK, CONTINUE}

868d099

Libs-API decided to remove these in rust-lang#102697. Follow-up to rust-lang#107023, which removed them from `compiler/`, but a couple new ones showed up since that was merged.

Remove from librustdoc and clippy too

c4fa0d3

Replace libc::{type} with crate::ffi::{type}

c50d3e2

Replace libc::{type} imports with crate::ffi::{type} outside of `std::sys` and `std::os`. Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>

Rollup merge of rust-lang#105524 - Ayush1325:libc-free, r=ChrisDenton

45430a5

Replace libc::{type} with crate::ffi::{type} Replace libc::{type} imports with crate::ffi::{type} outside of `std::sys` and `std::os`. Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>

Rollup merge of rust-lang#107355 - JohnTitor:issue-60755, r=compiler-…

b64a75f

…errors Add regression test for rust-lang#60755 Closes rust-lang#60755 r? compiler-errors Signed-off-by: Yuki Okushi <jtitor@2k36.org>

Rollup merge of rust-lang#107384 - Nilstrieb:bool-for-deletion, r=oli…

e0c8359

…-obk Remove `BOOL_TY_FOR_UNIT_TESTING` It is not used anymore for unit testing.

Rollup merge of rust-lang#107385 - BoxyUwU:ConstInferUnifier_is_folde…

18c9c64

…r, r=compiler-errors Use `FallibleTypeFolder` for `ConstInferUnifier` not `TypeRelation` I am not sure why this was using a `TypeRelation`, maybe it predates the ability to have fallible type folders

Rollup merge of rust-lang#107391 - notriddle:notriddle/copy-path-butt…

6bd09e0

…on, r=GuillaumeGomez rustdoc: remove inline javascript from copy-path button

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 28, 2023

bors merged commit bca8b4d into rust-lang:master Jan 28, 2023

rustbot added this to the 1.69.0 milestone Jan 28, 2023

rustbot added the perf-regression Performance regression. label Jan 28, 2023

matthiaskrgr deleted the rollup-b5vz2ow branch March 16, 2024 18:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 9 pull requests#107408

Rollup of 9 pull requests#107408
bors merged 22 commits intorust-lang:masterfrom
matthiaskrgr:rollup-b5vz2ow

matthiaskrgr commented Jan 28, 2023

Uh oh!

matthiaskrgr commented Jan 28, 2023

Uh oh!

bors commented Jan 28, 2023

Uh oh!

bors commented Jan 28, 2023

Uh oh!

bors commented Jan 28, 2023

Uh oh!

bors commented Jan 28, 2023

Uh oh!

rust-timer commented Jan 28, 2023

Uh oh!

rust-timer commented Jan 28, 2023

Uh oh!

rust-timer commented Jan 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Uh oh!

Conversation

matthiaskrgr commented Jan 28, 2023

Uh oh!

matthiaskrgr commented Jan 28, 2023

Uh oh!

bors commented Jan 28, 2023

Uh oh!

bors commented Jan 28, 2023

Uh oh!

bors commented Jan 28, 2023

Uh oh!

bors commented Jan 28, 2023

Uh oh!

rust-timer commented Jan 28, 2023

Uh oh!

rust-timer commented Jan 28, 2023

Uh oh!

rust-timer commented Jan 28, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants