Split alignment calculation from layout calculation#107742
Closed
oskgo wants to merge 14 commits intorust-lang:masterfrom
Closed
Split alignment calculation from layout calculation#107742oskgo wants to merge 14 commits intorust-lang:masterfrom
oskgo wants to merge 14 commits intorust-lang:masterfrom
Conversation
Collaborator
|
r? @eholk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Contributor
Author
|
r? ghost |
Collaborator
|
Failed to set assignee to
|
Contributor
|
@rustbot author (Setting as waiting on author since this is marked as a draft still) |
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
oskgo
force-pushed
the
split-align-from-layout
branch
from
b9e912f to
4994077
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
I don't have the confidence to make these changes without mentoring yet, so I'll close this. I might pick it back up once I'm more comfortable or if someone wants to mentor work on alignment, but this PR can be considered abandoned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactoring to simplify future work on alignment such as in #11924 and rust-lang/rfcs#3204.