Change src/etc/vscode_settings.json to always treat ./library as the sysroot source

[jyn514]

See
https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Frust-analyzer/topic/False.20error.20report.20for.20.60rust-analyzer.28private-field.29.60 for further discussion; previously this had various bugs.

I tested go-to-definition on:

• use std::io::Write in src/bootstrap/setup.rs
• use std::cell::RefCell in src/librustdoc/core.rs
• use rustc_span::symbol::sym in src/librustdoc/core.rs
• use std::fmt in compiler/rustc_span/src/symbol.rs
• Global in library/alloc/src/alloc/tests.rs

The following things still don't work:

• Global.deallocate in alloc/tests.rs. This function is under cfg(not(test)), so it can't be enabled without disabling RA in tests.rs altogether. I think this might be fixable by moving library/alloc/src/alloc/tests.rs to library/alloc/tests/alloc/lib.rs, so it's in a different crate, but I'd like to avoid blocking this improvement on that change.

cc @thomcc @BoxyUwU @spastorino - you've had issues with RA in the past, does this fix them? Are there any other use cases I should test? You can try these changes out by running cp src/etc/vscode_settings.json .vscode/settings.json, or running x setup and picking a random profile (it won't overwrite config.toml if it already exists). See #108135 for plans to make updating the config easier.

r? @Veykril

[rustbot]

Failed to set assignee to Veykril: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

[jyn514]

r? bootstrap - I feel pretty confident this is better than the status quo, but happy to make further improvements.

[jyn514]

cc @ozkanonur

[onur-ozkan]

I can't properly test this since I am not using Vscode.

Are you using vscode? @albertlarsan68

[albertlarsan68]

Yes I do.
r? @albertlarsan68

[jyn514]

@ozkanonur what editor are you using? There's instructions for how to use this with neovim on https://rustc-dev-guide.rust-lang.org/building/suggested.html#neovim

[onur-ozkan]

I am using neovim, but without the neoconf plugin that is mentioned in dev-guide. When I saw vscode in the PR title I thought PR is more related with vscode users. But it's actually all about lsp configuration, which means I can also test this. I will test the configuration and share the results here probably tomorrow morning.

[jyn514]

Ah, gotcha. Maybe we should rename that file to rust-analzyer-settings.json so it's more clear.

[onur-ozkan]

Sure, I think it's better naming for that file

[onur-ozkan]

All the notes you mentioned works like charm(I also tested go to reference) with this change. Plus, before this change, when I open compiler/rustc_attr/src/session_diagnostics.rs I had the following error from nvim lsp:

LSP[rust_analyzer] rust-analyzer failed to load workspace: Failed to find sysroot for Cargo.toml file /home/nimda/devspace/personal/rust/src/bootstrap/Cargo.toml.: can't load standard library from sysroot /ho
me/nimda/devspace/personal/rust/./build/host/stage0-sysroot
rust-analyzer failed to load workspace: Failed to find sysroot for Cargo.toml file /home/nimda/devspace/personal/rust/Cargo.toml.: can't load standard library from sysroot /home/nimda/devspace/personal/rust/.
/build/host/stage0-sysroot

And also Diagnostic was showing error proc macro `Diagnostic` not expanded: crate has not (yet) been built

This change fixes it. The error no longer exists, and Diagnostic doesn't show error. I can use signature help to get information about it, and also use go to definition on it.

[albertlarsan68]

Do you want to rename the file in this PR, or in another?
r=me if the rename is made as a follow-up.

[jyn514]

Let's do a follow-up, it ended up being slightly more complicated than I expected and I want to land this change since it works well :)

@bors r=albertlarsan68

[bors]

📌 Commit 6209e6c has been approved by albertlarsan68

It is now in the queue for this repository.

[jyn514]

@bors rollup

[onur-ozkan]

Do you want to rename the file in this PR, or in another? r=me if the rename is made as a follow-up.

Be aware that when the filename changes, some of the editors won't be able to detect this file and they will require some additional configurations.

[albertlarsan68]

The rename is about the checked in file (src/etc/vscode_settings.json to src/etc/rust_analyzer_settings.json or something like that), not the VS Code settings file.
The checked in file is not detected by any editor AFAIK.

[onur-ozkan]

Ah right, I confused it with .vscode/settings.json, my bad.

[albertlarsan68]

This rename means that the file may be used with others editors than VS Code.

[jyn514]

The file can already be used with other editors. This is just about making the name less confusing in review.