Merged
Conversation
it looks like Encodable was fallible at some point, but that was changed which means that this FIXME is no longer applicable
This makes it easier to understand.
This makes it easier to understand.
…o-handling, r=notriddle Fix handling of reexported macro in doc hidden items Fixes rust-lang#108231. Fixes rust-lang#59368. r? `@notriddle`
…ef-trait-refine, r=WaffleLapkin Refine error span for trait error into borrowed expression Extends the error span refinement in rust-lang#106477 to drill into borrowed expressions just like tuples/struct/enum literals. For example, ```rs trait Fancy {} trait Good {} impl <'a, T> Fancy for &'a T where T: Good {} impl <S> Good for Option<S> where S: Iterator {} fn want_fancy<F>(f: F) where F: Fancy {} fn example() { want_fancy(&Some(5)); // (BEFORE) ^^^^^^^^ `{integer}` is not an iterator // (AFTER) ^ `{integer}` is not an iterator } ``` Existing heuristics try to find the right part of the expression to "point at"; current heuristics look at e.g. struct constructors and tuples. This PR adds a new check for borrowed expressions when looking into a borrowed type.
…=cjgillot Remove old FIXMEs referring to rust-lang#19596 Having an inner function that accepts a mutable reference seems to be the only way this can be expressed. Taking a mutable reference would call the same function with a new type &mut F which then causes the infinite recursion error in rust-lang#19596.
Remove old FIXME that no longer applies it looks like Encodable was fallible at some point, but that was changed which means that this FIXME is no longer applicable
small `opaque_type_origin` cleanup r? `@oli-obk`
Use named arguments for `{,u}int_impls` macro
This makes it way easier to understand.
r? `@scottmcm`
rustbot
added
S-waiting-on-review
Member
Author
|
@bors r+ rollup=never p=9 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: previous master: 5243ea5c29 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Feb 21, 2023
Collaborator
|
Finished benchmarking commit (8f55d60): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
opaque_type_origincleanup #108276 (smallopaque_type_origincleanup){,u}int_implsmacro #108279 (Use named arguments for{,u}int_implsmacro)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup