add missing feature in core/tests#108558
Merged
bors merged 1 commit intorust-lang:masterfrom Mar 1, 2023
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Member
|
The way core tests work is really cursed, so it's not unthinkable that there's weird stuff that gets through without needing something like this. Seems worth investigating, though... @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Feb 28, 2023
add missing feature in core/tests rust-lang#104265 introduced the `ip_in_core` feature. For some reason core tests seem to still build without that feature -- no idea how that is possible. Might be related to rust-lang#15702? I was under the impression that `pub use` with different stability doesn't actually work. That's why `intrinsics::transmute` is stable, for example. Either way, core tests fail to build in miri-test-libstd, and adding the feature fixes that. r? `@thomcc`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 28, 2023
add missing feature in core/tests rust-lang#104265 introduced the `ip_in_core` feature. For some reason core tests seem to still build without that feature -- no idea how that is possible. Might be related to rust-lang#15702? I was under the impression that `pub use` with different stability doesn't actually work. That's why `intrinsics::transmute` is stable, for example. Either way, core tests fail to build in miri-test-libstd, and adding the feature fixes that. r? ``@thomcc``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 1, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#108297 (Exit when there are unmatched delims to avoid noisy diagnostics) - rust-lang#108531 (rustdoc: Show that repeated expression arrays can be made with constant values) - rust-lang#108536 (Update books) - rust-lang#108550 (Remove the `capture_disjoint_fields` feature) - rust-lang#108551 (Descriptive error when users try to combine RPITIT/AFIT with specialization) - rust-lang#108554 (Only look for param in item's generics if it actually comes from generics) - rust-lang#108555 (Fix a race in the query system) - rust-lang#108558 (add missing feature in core/tests) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#104265 introduced the
ip_in_corefeature. For some reason core tests seem to still build without that feature -- no idea how that is possible. Might be related to #15702? I was under the impression thatpub usewith different stability doesn't actually work. That's whyintrinsics::transmuteis stable, for example.Either way, core tests fail to build in miri-test-libstd, and adding the feature fixes that.
r? @thomcc