Remove duplicate guard in diagnostic method suggest#108574
Closed
Jesse-Bakker wants to merge 1 commit intorust-lang:masterfrom
Closed
Remove duplicate guard in diagnostic method suggest#108574Jesse-Bakker wants to merge 1 commit intorust-lang:masterfrom
Jesse-Bakker wants to merge 1 commit intorust-lang:masterfrom
Conversation
This was leftover after refactoring in c183110
Collaborator
|
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Member
|
Instead of removing this duplicate check we should make it work how it did before it was changed in #104422 It would be great to find a testcase that changes when fixing this if statement if possible |
Contributor
Author
|
I see that this was noticed in #107753. I'll see if I can come up with a test case for a bit. Otherwise, I'll close this PR. |
TaKO8Ki
added
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was leftover after refactoring in c183110