rustdoc: add support for type filters in arguments and generics

[notriddle]

This makes sense, since the search index has the information in it, and it's more useful for function signature searches since a function signature search's item type is, by definition, some type of function (there's more than one, but not very many).

[rustbot]

r? @jsha

(rustbot has picked a reviewer for you, use r? to override)

[rustbot]

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

[notriddle]

@rfcbot fcp merge

[rfcbot]

Team member @notriddle has proposed to merge this. The next step is review by the rest of the tagged team members:

• @GuillaumeGomez
• @Manishearth
• @Nemo157
• @aDotInTheVoid
• @camelid
• @jsha
• @notriddle

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

[GuillaumeGomez]

Overall, looks good to me. Just needs an update in the help popup docs about search and eventually in the rustdoc book but I don't remember us having a chapter about search, might be worth adding one at some point.

[bors]

☔ The latest upstream changes (presumably #108677) made this pull request unmergeable. Please resolve the merge conflicts.

[Manishearth]

Can you post some screenshots or examples of what this actually enables?

[notriddle]

Using this feature allows you to distinguish multiple items with the same name, but different kinds, when searching by function signature.

In the standard library, that's primitive:fn and trait:Fn. For another example, diesel's struct:Never is also completely different from primitive:never ¹. Primitives are really the spot where you'd want this, because other kinds have paths that you'd use for disambiguation instead of using the kind.

This means I should be able to search -> struct:Never on Diesel to find ways to construct the Never struct, but that doesn't work, and -> never gives me a list of all functions that diverge.

Footnotes

1. I do plan to open a PR in the future that desugars ! to primitive:never in the search query parser, and desugaring [T] to something like primitive:slice<T>. ↩

[Manishearth]

Ah, makes sense to me

[camelid]

eventually in the rustdoc book but I don't remember us having a chapter about search, might be worth adding one at some point.

We do have a small section already that could be expanded: https://doc.rust-lang.org/nightly/rustdoc/how-to-read-rustdoc.html#the-search-interface

[bors]

☔ The latest upstream changes (presumably #109056) made this pull request unmergeable. Please resolve the merge conflicts.

[rfcbot]

🔔 This is now entering its final comment period, as per the review above. 🔔

[bors]

☔ The latest upstream changes (presumably #109376) made this pull request unmergeable. Please resolve the merge conflicts.

[rfcbot]

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

[GuillaumeGomez]

@bors r+ rollup

[bors]

📌 Commit cae4385 has been approved by GuillaumeGomez

It is now in the queue for this repository.