prefer universal region from lower universe in region unification table#108899
Closed
aliemjay wants to merge 7 commits intorust-lang:masterfrom
Closed
prefer universal region from lower universe in region unification table#108899aliemjay wants to merge 7 commits intorust-lang:masterfrom
aliemjay wants to merge 7 commits intorust-lang:masterfrom
Conversation
Give a more clear name.
Bless tests and show an introduced unsoundness related to
exits<'a> { forall<'b> { 'a == 'b } }.
We now resolve the var ?a in U0 to the placeholder !b in U1.
In case a variable is unified with two universal regions from different universes, use the one with the lower universe as it has a higher chance of being compatible with the variable.
rustbot
added
S-waiting-on-review
Contributor
|
r=me once #108121 lands (or feel free to put it back into 108121. I saw your comment and the commit) |
Contributor
Author
|
Ok I'll put it back in #108121 because it seems bors is not happy with my changes and needs a new review anway. Sorry for the inconvenience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
followup for #108121
r? @lcnr (feel free to reassign)