Remove box expressions from HIR

[clubby789]

After #108516, #[rustc_box] is used at HIR->THIR lowering and this is no longer emitted, so it can be removed.

This is based on top of #108471 to help with conflicts, so 43490488ccacd1a822e9c621f5ed6fca99959a0b is the only relevant commit (sorry for all the duplicated pings!)

@rustbot label +S-blocked

[rustbot]

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

[rustbot]

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in src/tools/rust-analyzer

cc @rust-lang/wg-rls-2

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

[bors]

☔ The latest upstream changes (presumably #102256) made this pull request unmergeable. Please resolve the merge conflicts.

[clubby789]

@rustbot label -S-blocked

[compiler-errors]

Thanks @clubby789

r? @compiler-errors @bors r+

[bors]

📌 Commit 9afffc5 has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 9afffc5 with merge cbc0ed224b1d016d848854f459692bfe8bc2e08e...

[bors]

💔 Test failed - checks-actions

[rust-log-analyzer]

The job i686-mingw-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[2571/3021] Linking CXX static library lib\libLLVMMCJIT.a
[2572/3021] Linking CXX executable bin\yaml-bench.exe
[2573/3021] Linking CXX static library lib\libLLVMAggressiveInstCombine.a
[2574/3021] Linking CXX static library lib\libLLVMVectorize.a
FAILED: lib/libLLVMVectorize.a 
cmd.exe /C "cd . && "C:\Program Files\CMake\bin\cmake.exe" -E rm -f lib\libLLVMVectorize.a && D:\a\rust\rust\mingw32\bin\ar.exe qc lib\libLLVMVectorize.a  lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/LoadStoreVectorizer.cpp.obj lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/LoopVectorizationLegality.cpp.obj lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/LoopVectorize.cpp.obj lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/SLPVectorizer.cpp.obj lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/Vectorize.cpp.obj lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/VectorCombine.cpp.obj lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/VPlan.cpp.obj lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/VPlanHCFGBuilder.cpp.obj lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/VPlanRecipes.cpp.obj lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/VPlanSLP.cpp.obj lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/VPlanTransforms.cpp.obj lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/VPlanVerifier.cpp.obj && D:\a\rust\rust\mingw32\bin\ranlib.exe lib\libLLVMVectorize.a && cd ."
D:\a\rust\rust\mingw32\bin\ar.exe: could not create temporary file whilst writing archive: no more archived files
[2575/3021] Building CXX object tools/lto/CMakeFiles/LTO.dir/lto.cpp.obj
[2576/3021] Linking CXX static library lib\libLLVMInstrumentation.a
[2577/3021] Linking CXX static library lib\libLLVMObjCARCOpts.a
[2578/3021] Linking CXX static library lib\libLLVMInstCombine.a
[2578/3021] Linking CXX static library lib\libLLVMInstCombine.a
[2579/3021] Linking CXX executable bin\llvm-config.exe
[2580/3021] Building CXX object tools/llvm-lto/CMakeFiles/llvm-lto.dir/llvm-lto.cpp.obj
[2581/3021] Linking CXX executable bin\llvm-profdata.exe
ninja: build stopped: subcommand failed.
command did not execute successfully, got: exit code: 1


build script failed, must exit now', C:\Users\runneradmin\.cargo\registry\src\index.crates.io-1cd66030c949c28d\cmake-0.1.48\src\lib.rs:975:5
 finished in 280.943 seconds
Build completed unsuccessfully in 0:06:26
Build completed unsuccessfully in 0:06:26
make: *** [Makefile:80: ci-mingw-subset-2] Error 1

[Noratrieb]

ar, try harder.
@bors retry

[matthiaskrgr]

It looks like this caused a couple of false positives in clippy regarding the redundant_clone lint (unfortunately we didn't have tests for this before).

Here is a list of files where clippy now suggests invalid removal of clone()s and suggests code that no longer compiles

"./library/alloc/src/tests.rs",
"./src/doc/book/listings/ch04-understanding-ownership/no-listing-05-clone/src/main.rs",
"./src/tools/miri/tests/pass/rc.rs",
"./tests/ui/derives/derive-macro-const-default.rs",
"./tests/ui/impl-trait/universal_multiple_bounds.rs",
"./tests/ui/structs-enums/struct-lit-functional-no-fields.rs",
"./tests/ui/threads-sendsync/task-comm-6.rs",
"./tests/ui/unique/unique-decl-init-copy.rs",

rust-lang/rust-clippy#10517