Rollup of 7 pull requests by Dylan-DPC · Pull Request #109164 · rust-lang/rust

Dylan-DPC · 2023-03-15T12:21:35Z

Successful merges:

add enable-warnings flag for llvm, and disable it by default. #108991 (add enable-warnings flag for llvm, and disable it by default.)
Use unused_generic_params from crate metadata #109109 (Use unused_generic_params from crate metadata)
Create dirs for build_triple #109111 (Create dirs for build_triple)
Simplify proc macro signature validity check #109136 (Simplify proc macro signature validity check)
Update cargo #109150 (Update cargo)
Fix MappingToUnit to support no span of arg_ty #109154 (Fix MappingToUnit to support no span of arg_ty)
Remove mw from review rotation for a while #109157 (Remove mw from review rotation for a while)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

14 commits in 7d3033d2e59383fd76193daf9423c3d141972a7d..4a3c588b1f0a8e2dc8dd8789dbf3b6a71b02ed49 2023-03-08 17:05:08 +0000 to 2023-03-14 14:05:36 +0000 - ci: make clean-test-output a script for reuse (rust-lang/cargo#11848) - Accurately show status when downgrading dependencies (rust-lang/cargo#11839) - docs(contrib): Move Design Principles earlier in the book (rust-lang/cargo#11842) - docs(contrib): Point compilation docs to doc comments (rust-lang/cargo#11841) - `cargo install --git` multiple packages with binaries found hint (rust-lang/cargo#11835) - Disable flaky auth tests when `gitoxide` runs them (rust-lang/cargo#11830) - Add some documentation on writing cross-compilation tests (rust-lang/cargo#11825) - chore: Use sparse protocol on stable CI (rust-lang/cargo#11829) - Notice for potential unexpected shell expansions in help text of `cargo-add` (rust-lang/cargo#11826) - Add tracking issue to gitoxide unstable docs (rust-lang/cargo#11822) - Bump crates-io to 0.36.0 (rust-lang/cargo#11820) - Bump to 0.71.0; update changelog (rust-lang/cargo#11815) - docs(contrib): Move overview to lib (rust-lang/cargo#11809) - Fix semver check for 1.68 (rust-lang/cargo#11817)

…f func

Signed-off-by: ozkanonur <work@onurozkan.dev>

…arsan68 add `enable-warnings` flag for llvm, and disable it by default. This flag allows to turn off warnings of llvm compilation for people who are not interested on those warnings.

…gn, r=Nilstrieb Use `unused_generic_params` from crate metadata Due to the way that `separate_provide_extern` interacted with the implementation of `<ty::InstanceDef<'tcx> as Key>::query_crate_is_local`, we actually never hit the foreign provider for `unused_generic_params`. Additionally, since the *local* provider of `unused_generic_params` calls `should_polymorphize`, which always returns false if the def-id is foreign, this means that we never actually polymorphize monomorphic instances originating from foreign crates. We don't actually encode `unused_generic_params` for items where all generics are used, so I had to tweak the foreign provider to fall back to `ty::UnusedGenericParams::new_all_used()` to avoid more ICEs when the above bugs were fixed.

Create dirs for build_triple Fixes rust-lang#109103

…o-checking, r=oli-obk Simplify proc macro signature validity check Use an `ObligationCtxt` instead of `normalize_erasing_regions` + `DeepRejectCtxt`. This should both give us a more accurate error message, and also avoid issues like not-well-formed proc macro signatures. Also, let's fall back on the regular type mismatch error reporting for making these diagnostic notes, instead of hard-coding a bunch of specific diagnostics. Fixes rust-lang#109129

Update cargo 14 commits in 7d3033d2e59383fd76193daf9423c3d141972a7d..4a3c588b1f0a8e2dc8dd8789dbf3b6a71b02ed49 2023-03-08 17:05:08 +0000 to 2023-03-14 14:05:36 +0000 - ci: make clean-test-output a script for reuse (rust-lang/cargo#11848) - Accurately show status when downgrading dependencies (rust-lang/cargo#11839) - docs(contrib): Move Design Principles earlier in the book (rust-lang/cargo#11842) - docs(contrib): Point compilation docs to doc comments (rust-lang/cargo#11841) - `cargo install --git` multiple packages with binaries found hint (rust-lang/cargo#11835) - Disable flaky auth tests when `gitoxide` runs them (rust-lang/cargo#11830) - Add some documentation on writing cross-compilation tests (rust-lang/cargo#11825) - chore: Use sparse protocol on stable CI (rust-lang/cargo#11829) - Notice for potential unexpected shell expansions in help text of `cargo-add` (rust-lang/cargo#11826) - Add tracking issue to gitoxide unstable docs (rust-lang/cargo#11822) - Bump crates-io to 0.36.0 (rust-lang/cargo#11820) - Bump to 0.71.0; update changelog (rust-lang/cargo#11815) - docs(contrib): Move overview to lib (rust-lang/cargo#11809) - Fix semver check for 1.68 (rust-lang/cargo#11817) r? `@ghost`

…mpiler-errors Fix MappingToUnit to support no span of arg_ty Fixes rust-lang#109152

…crum Remove mw from review rotation for a while I'm triple booked right now 📚

Dylan-DPC · 2023-03-15T12:22:44Z

@bors r+ rollup=never p=5

bors · 2023-03-15T12:22:46Z

📌 Commit ff8f659 has been approved by Dylan-DPC

It is now in the queue for this repository.

bors · 2023-03-15T14:50:07Z

⌛ Testing commit ff8f659 with merge a167cbd...

bors · 2023-03-15T18:29:57Z

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing a167cbd to master...

bors · 2023-03-15T18:29:57Z

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing a167cbd to master...

rust-timer · 2023-03-15T18:30:06Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha

previous master: a167cbddac

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-03-15T18:31:59Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#109157	331adb8e07088b7e5d350d4ec48ca5aa7e3d7b4b
#109154	50b8857a2cbc708c7b0880c3821afaf3534e7d1f
#109150	a802d692fa30530eff7c8744af98d7eae6a38174
#109136	6927c1eb7d26840da501db09d3e5dc6926fe5331
#109111	dda0d45acf828aab997c16813866bd31f1fc78b9
#109109	6ab88825a5aaae06826d38898aa0435b924fe440
#108991	3fc7b4174be3fd8d1633a03fae25d7cf56019ff0

previous master: e4b9f86054

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-03-17T05:05:11Z

Finished benchmarking commit (a167cbd): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.5%	[4.5%, 4.5%]	1
Regressions ❌ (secondary)	2.9%	[2.6%, 3.1%]	2
Improvements ✅ (primary)	-1.7%	[-1.7%, -1.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.4%	[-1.7%, 4.5%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.0%	[4.9%, 5.1%]	2
Improvements ✅ (primary)	-2.3%	[-3.0%, -1.8%]	10
Improvements ✅ (secondary)	-2.1%	[-2.7%, -1.4%]	23
All ❌✅ (primary)	-2.3%	[-3.0%, -1.8%]	10

mu001999 and others added 15 commits March 14, 2023 11:22

Create dir for build_triple

a4692f4

Use unused_generic_params from crate metadata

ee2d428

Simplify proc macro signature validity check

9eae773

Tighter spans

00dc3b2

Fix rust-lang#109152, fix the scenario that we may can not get span o…

b3af5e2

…f func

Remove mw from review rotation.

a9f3db6

add enable-warnings flag for llvm

2e7249f

Signed-off-by: ozkanonur <work@onurozkan.dev>

Rollup merge of rust-lang#108991 - ozkanonur:new-llvm-flag, r=albertl…

c11399b

…arsan68 add `enable-warnings` flag for llvm, and disable it by default. This flag allows to turn off warnings of llvm compilation for people who are not interested on those warnings.

Rollup merge of rust-lang#109111 - MU001999:master, r=jyn514

d133c36

Create dirs for build_triple Fixes rust-lang#109103

Rollup merge of rust-lang#109154 - chenyukang:yukang/fix-109152, r=co…

19d5758

…mpiler-errors Fix MappingToUnit to support no span of arg_ty Fixes rust-lang#109152

Rollup merge of rust-lang#109157 - michaelwoerister:tb, r=Mark-Simula…

ff8f659

…crum Remove mw from review rotation for a while I'm triple booked right now 📚

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2023

bors added merged-by-bors This PR was explicitly merged by bors. labels Mar 15, 2023

bors merged commit a167cbd into rust-lang:master Mar 15, 2023

rustbot added this to the 1.70.0 milestone Mar 15, 2023

This was referenced Mar 15, 2023

Add RUSTC_EMIT option to pass on --emit to crates during bootstrap #108365

Closed

Make cargo a workspace #109133

Merged

#108240 Rename 'src/bootstrap/native.rs' to llvm.rs #109138

Closed

Dylan-DPC deleted the rollup-0bwxwos branch March 16, 2023 10:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests#109164

Rollup of 7 pull requests#109164
bors merged 15 commits intorust-lang:masterfrom
Dylan-DPC:rollup-0bwxwos

Dylan-DPC commented Mar 15, 2023

Uh oh!

Dylan-DPC commented Mar 15, 2023

Uh oh!

bors commented Mar 15, 2023

Uh oh!

bors commented Mar 15, 2023

Uh oh!

bors commented Mar 15, 2023

Uh oh!

bors commented Mar 15, 2023

Uh oh!

rust-timer commented Mar 15, 2023

Uh oh!

rust-timer commented Mar 15, 2023

Uh oh!

rust-timer commented Mar 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

Dylan-DPC commented Mar 15, 2023

Uh oh!

Dylan-DPC commented Mar 15, 2023

Uh oh!

bors commented Mar 15, 2023

Uh oh!

bors commented Mar 15, 2023

Uh oh!

bors commented Mar 15, 2023

Uh oh!

bors commented Mar 15, 2023

Uh oh!

rust-timer commented Mar 15, 2023

Uh oh!

rust-timer commented Mar 15, 2023

Uh oh!

rust-timer commented Mar 17, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants