Rollup of 8 pull requests by matthiaskrgr · Pull Request #109303 · rust-lang/rust

matthiaskrgr · 2023-03-18T11:04:25Z

Successful merges:

Error code E0794 for late-bound lifetime parameter error. #107416 (Error code E0794 for late-bound lifetime parameter error.)
Speed up tidy quite a lot #108772 (Speed up tidy quite a lot)
Add revisions for -Zlower-impl-trait-in-trait-to-assoc-ty fixed tests #109193 (Add revisions for -Zlower-impl-trait-in-trait-to-assoc-ty fixed tests)
Tweak implementation of overflow checking assertions #109234 (Tweak implementation of overflow checking assertions)
Fix generics mismatch errors for RPITITs on -Zlower-impl-trait-in-trait-to-assoc-ty #109238 (Fix generics mismatch errors for RPITITs on -Zlower-impl-trait-in-trait-to-assoc-ty)
rustdoc: reduce allocations in visibility_to_src_with_space #109283 (rustdoc: reduce allocations in visibility_to_src_with_space)
Use size_of_val instead of manual calculation #109287 (Use size_of_val instead of manual calculation)
Stabilise unix_socket_abstract #109288 (Stabilise unix_socket_abstract)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Extract and reuse logic controlling behaviour of overflow checking assertions instead of duplicating it three times.

…it-to-assoc-ty

Very minor thing that I happened to notice in passing, but it's both shorter and means it gets `mul nuw`, so why not.

Fixes rust-lang#85410

This makes it easier to profile.

- Skip files in `skip` wherever possible to avoid reading their contents - Don't look for `tidy-alphabetic-start` in tests. It's never currently used and slows the check down a lot. - Add new `filter_not_rust` helper function

Previously, it would walk each directory twice: once in the main `Walk` iterator, and once to count the number of entries in the directory. Now it only walks each directory once.

This has a significant speedup for me locally, from about 1.3 seconds to .9 seconds.

Error code E0794 for late-bound lifetime parameter error. This PR addresses [rust-lang#80618](rust-lang#80618).

Speed up tidy quite a lot I highly recommend reviewing this commit-by-commit. Based on rust-lang#106440 for convenience. ## Timings These were collected by running `x test tidy -v` to copy paste the command, then using [`samply record`](https://github.com/mstange/samply). before (8 threads) ![image](https://user-images.githubusercontent.com/23638587/222965319-352ad2c8-367c-4d74-960a-e4bb161a6aff.png) after (8 threads) ![image](https://user-images.githubusercontent.com/23638587/222965323-fa846f4e-727a-4bf8-8e3b-1b7b40505cc3.png) before (64 threads) ![image](https://user-images.githubusercontent.com/23638587/222965302-dc88020c-19e9-49d9-a87d-cad054d717f3.png) after (64 threads) ![image](https://user-images.githubusercontent.com/23638587/222965335-e73d7622-59de-41d2-9cc4-1bd67042a349.png) The last commit makes tidy use more threads, so comparing "before (8 threads)" to "after (64 threads)" is IMO the most realistic comparison. Locally, that brings the time for me to run tidy down from 4 to .9 seconds, i.e. the majority of the time for `x test tidy` is now spend running `fmt --check`. r? `@the8472`

…er-errors Add revisions for -Zlower-impl-trait-in-trait-to-assoc-ty fixed tests Needs to go on top of rust-lang#109198 r? ``@compiler-errors``

Tweak implementation of overflow checking assertions Extract and reuse logic controlling behaviour of overflow checking assertions instead of duplicating it three times. r? `@cjgillot`

…er-errors Fix generics mismatch errors for RPITITs on -Zlower-impl-trait-in-trait-to-assoc-ty This PR stops reporting errors due to different count of generics on the new synthesized associated types for RPITITs. Those were already reported when we compare the function on the triat with the function on the impl. r? ``@compiler-errors``

…src-with-space, r=jsha rustdoc: reduce allocations in `visibility_to_src_with_space`

…=oli-obk Use `size_of_val` instead of manual calculation Very minor thing that I happened to notice in passing, but it's both shorter and [means it gets `mul nsw`](https://rust.godbolt.org/z/Y9KxYETv5), so why not.

…dr, r=joshtriplett Stabilise `unix_socket_abstract` Fixes rust-lang#85410

matthiaskrgr · 2023-03-18T11:06:20Z

@bors r+ rollup=never p=8

bors · 2023-03-18T11:06:22Z

📌 Commit 49a1528 has been approved by matthiaskrgr

It is now in the queue for this repository.

matthiaskrgr · 2023-03-18T11:07:27Z

Trying to see if the error in #109285 is maybe caused by #108148 or #109266 :/

bors · 2023-03-18T11:19:33Z

⌛ Testing commit 49a1528 with merge f177b7c...

bors · 2023-03-18T14:50:00Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing f177b7c to master...

rust-timer · 2023-03-18T14:52:17Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#109288	6988df7f5d38377eb21ea6e2cce370ce9a302902
#109287	bcbf23fb119a58241d37dd16dac5ecb62b6cbcb4
#109283	82de647c7b7220f8827429ffa9dfee9107f6697a
#109238	b675a879cb318f83797c4d9537484bac91389a9c
#109234	044e3430dd19ae07cb402f42472f71c25e9d562a
#109193	b76adce64bef7421246b8df2773e7675139f39df
#108772	af6bc4b85f99c557b5d37948c4342023183c4e1d
#107416	e68d4ed4eb53b1b2eec25dd2cadcc22ae792f385

previous master: df61fcaec1

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-03-18T20:04:21Z

Finished benchmarking commit (f177b7c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.9%	[-1.3%, -0.5%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.5%	[-1.3%, 0.5%]	4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.5%, 0.8%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.5%, 0.8%]	3

czzrr and others added 22 commits March 7, 2023 21:26

Error code E0794 for late-bound lifetime parameter error.

75563cd

Tweak implementation of overflow checking assertions

27b430b

Extract and reuse logic controlling behaviour of overflow checking assertions instead of duplicating it three times.

Fix generics mismatch errors for RPITITs on -Zlower-impl-trait-in-tra…

c7cc1c7

…it-to-assoc-ty

Add generic parameters mismatch test for async in traits

ae7fa1d

Add revisions for -Zlower-impl-trait-in-trait-to-assoc-ty fixed tests

e0302bb

rustdoc: reduce allocations in visibility_to_src_with_space

8628e27

Use size_of_val instead of manual calculation

3508879

Very minor thing that I happened to notice in passing, but it's both shorter and means it gets `mul nuw`, so why not.

Stabilise unix_socket_abstract

a3f3db8

Fixes rust-lang#85410

Use named threads in tidy

c76e260

This makes it easier to profile.

Speed up file walking in tidy

9b606a3

- Skip files in `skip` wherever possible to avoid reading their contents - Don't look for `tidy-alphabetic-start` in tests. It's never currently used and slows the check down a lot. - Add new `filter_not_rust` helper function

Make ui_tests non-quadratic

d26a155

Previously, it would walk each directory twice: once in the main `Walk` iterator, and once to count the number of entries in the directory. Now it only walks each directory once.

Use a single WalkBuilder for multiple paths

19b272a

Let tidy use more threads

3a58b2b

This has a significant speedup for me locally, from about 1.3 seconds to .9 seconds.

address review comments

675c4aa

Rollup merge of rust-lang#107416 - czzrr:issue-80618, r=GuillaumeGomez

9599f3c

Error code E0794 for late-bound lifetime parameter error. This PR addresses [rust-lang#80618](rust-lang#80618).

Rollup merge of rust-lang#109193 - spastorino:new-rpitit-11, r=compil…

a79925d

…er-errors Add revisions for -Zlower-impl-trait-in-trait-to-assoc-ty fixed tests Needs to go on top of rust-lang#109198 r? ``@compiler-errors``

Rollup merge of rust-lang#109234 - tmiasko:overflow-checks, r=cjgillot

a48d83d

Tweak implementation of overflow checking assertions Extract and reuse logic controlling behaviour of overflow checking assertions instead of duplicating it three times. r? `@cjgillot`

Rollup merge of rust-lang#109283 - notriddle:notriddle/visibility-to-…

e81a072

…src-with-space, r=jsha rustdoc: reduce allocations in `visibility_to_src_with_space`

Rollup merge of rust-lang#109288 - jmillikin:linux-abstract-socket-ad…

49a1528

…dr, r=joshtriplett Stabilise `unix_socket_abstract` Fixes rust-lang#85410

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 18, 2023

bors merged commit f177b7c into rust-lang:master Mar 18, 2023

rustbot added this to the 1.70.0 milestone Mar 18, 2023

This was referenced Mar 18, 2023

Perform unused assignment and unused variables lints on MIR. #101500

Closed

Less as * in library/core #109255

Closed

matthiaskrgr deleted the rollup-usj4ef5 branch March 16, 2024 18:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 8 pull requests#109303

Rollup of 8 pull requests#109303
bors merged 22 commits intorust-lang:masterfrom
matthiaskrgr:rollup-usj4ef5

matthiaskrgr commented Mar 18, 2023

Uh oh!

matthiaskrgr commented Mar 18, 2023

Uh oh!

bors commented Mar 18, 2023

Uh oh!

matthiaskrgr commented Mar 18, 2023

Uh oh!

bors commented Mar 18, 2023

Uh oh!

bors commented Mar 18, 2023

Uh oh!

rust-timer commented Mar 18, 2023

Uh oh!

rust-timer commented Mar 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Uh oh!

Conversation

matthiaskrgr commented Mar 18, 2023

Uh oh!

matthiaskrgr commented Mar 18, 2023

Uh oh!

bors commented Mar 18, 2023

Uh oh!

matthiaskrgr commented Mar 18, 2023

Uh oh!

bors commented Mar 18, 2023

Uh oh!

bors commented Mar 18, 2023

Uh oh!

rust-timer commented Mar 18, 2023

Uh oh!

rust-timer commented Mar 18, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants