Make EvalCtxt's infcx private#109511
Merged
bors merged 2 commits intorust-lang:masterfrom Mar 30, 2023
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
compiler-errors
commented
Mar 23, 2023
BoxyUwU
reviewed
Mar 23, 2023
rust-cloud-vms
bot
force-pushed
the
eval-ctxt-infcx-private
branch
from
62819ba to
5c570aa
Compare
Collaborator
|
☔ The latest upstream changes (presumably #109517) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
force-pushed
the
eval-ctxt-infcx-private
branch
from
5c570aa to
2420699
Compare
rust-cloud-vms
bot
force-pushed
the
eval-ctxt-infcx-private
branch
from
2420699 to
3362143
Compare
lcnr
reviewed
Mar 29, 2023
Contributor
lcnr
left a comment
lcnr
left a comment
There was a problem hiding this comment.
a few nits which you may or may not fix
after that r=me
compiler/rustc_trait_selection/src/solve/eval_ctxt/canonical.rs
Outdated
Show resolved
Hide resolved
compiler-errors
force-pushed
the
eval-ctxt-infcx-private
branch
from
3362143 to
a61616a
Compare
Contributor
Author
|
@bors r=lcnr rollup (only affects new solver) |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 29, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#107387 (Use random `HashMap` keys on Hermit) - rust-lang#109511 (Make `EvalCtxt`'s `infcx` private) - rust-lang#109554 (Suggest ..= when someone tries to create an overflowing range) - rust-lang#109675 (Do not consider elaborated projection predicates for objects in new solver) - rust-lang#109693 (Remove ~const from alloc) - rust-lang#109700 (Lint against escape sequences in Fluent files) - rust-lang#109716 (Move `mir::Field` → `abi::FieldIdx`) - rust-lang#109726 (rustdoc: Don't strip crate module) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To better protect against people doing bad things with the inner
InferCtxtr? @lcnr