Rollup of 6 pull requests#109625
Closed
matthiaskrgr wants to merge 13 commits intorust-lang:masterfrom
Closed
Conversation
Since structs are always `VariantIdx(0)`, there's a bunch of files where the only reason they had `VariantIdx` or `vec::Idx` imported at all was to get the first variant. So this uses a constant for that, and adds some doc-comments to `VariantIdx` while I'm there, since it doesn't have any today.
…rs-rustdoc, r=GuillaumeGomez rustdoc + rustdoc-json support for `feature(non_lifetime_binders)` Makes `for<T> T: Trait` and `for<const N: usize> ..` in where clause operate correctly. Fixes rust-lang#108158
… r=GuillaumeGomez Rustdoc Book refer to rustdoc::missing_doc_code_examples. Fixes rust-lang#109592. Fixes rust-lang#109592. But, please see a related question at rust-lang#109592 (item `2.`).
…to-hide-trait, r=notriddle Improve "Auto-hide trait implementation documentation" GUI test Part of rust-lang#66181. I'll start working on the `include` command for `browser-ui-test` so we can greatly reduce the duplicated code between setting tests. r? `@notriddle`
…urther-specializable, r=BoxyUwU Still-further-specializable projections are ambiguous in new solver Fixes https://github.com/rust-lang/rust/pull/108896/files#r1148450781 r? `@BoxyUwU` (though feel free to re-roll) --- This can be used to create an unsound transmute function with the new solver: ```rust #![feature(specialization)] trait Default { type Id; fn intu(&self) -> &Self::Id; } impl<T> Default for T { default type Id = T; fn intu(&self) -> &Self::Id { self } } fn transmute<T: Default<Id = U>, U: Copy>(t: T) -> U { *t.intu() } use std::num::NonZeroU8; fn main() { let s = transmute::<u8, Option<NonZeroU8>>(0); assert_eq!(s, None); } ```
Correct typo (`back_box` -> `black_box`)
…iler-errors Refactor: `VariantIdx::from_u32(0)` -> `FIRST_VARIANT` Since structs are always `VariantIdx(0)`, there's a bunch of files where the only reason they had `VariantIdx` or `vec::Idx` imported at all was to get the first variant. So this uses a constant for that, and adds some doc-comments to `VariantIdx` while I'm there, since [it doesn't have any today](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_target/abi/struct.VariantIdx.html).
rustbot
added
A-rustdoc-json
Member
Author
|
@bors r+ rollup=never p=6 |
Collaborator
Collaborator
|
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
feature(non_lifetime_binders)#108335 (rustdoc + rustdoc-json support forfeature(non_lifetime_binders))missing_doc_code_exampleswithrustdoc::missing_doc_code_examples#109592.)back_box->black_box) #109620 (Correct typo (back_box->black_box))VariantIdx::from_u32(0)->FIRST_VARIANT#109621 (Refactor:VariantIdx::from_u32(0)->FIRST_VARIANT)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup