Merged
Conversation
…rt-intra-doc-ice, r=petrochenkov rustdoc: Fix ICE for intra-doc link on intermediate re-export Fixes rust-lang#109282. This PR is based on rust-lang#109266 as it includes its commit to make this work. `@petrochenkov:` It was exactly as you predicted, adding the `DefId` to the attributes fixed the error for intermediate re-exports as well. Thanks a lot! r? `@petrochenkov`
…errors Remove the `NodeId` of `ast::ExprKind::Async` This is a followup to rust-lang#104833 (review). In my original attempt, I was using `LoweringContext::expr`, which was not correct as it creates a fresh `DefId`. It now uses the correct `DefId` for the wrapping `Expr`, and also makes forwarding `#[track_caller]` attributes more explicit.
…anonur Allow passing the --nocapture flag to compiletest closes rust-lang#109407
…ve, r=Mark-Simulacrum bump `askama_derive` to 0.12.1 Which uses syn 2.0. cc rust-lang#109302
Add missing needs-asm-support annotation to ui/simple_global_asm.rs
…e1-dead Correct ASCII case comment Fixes rust-lang#109508
rustbot
added
A-testsuite
Member
Author
|
@bors r+ rollup=never p=6 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: previous master: dd19135b04 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Mar 27, 2023
Collaborator
|
Finished benchmarking commit (2036fdd): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
NodeIdofast::ExprKind::Async#109354 (Remove theNodeIdofast::ExprKind::Async)askama_deriveto 0.12.1 #109512 (bumpaskama_deriveto 0.12.1)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup