Improve safe transmute error reporting by bryangarza · Pull Request #109800 · rust-lang/rust

bryangarza · 2023-03-31T02:44:28Z

This patch updates the error reporting when Safe Transmute is not possible between 2 types by including the reason.

Also, fix some small bugs that occur when computing the Answer for transmutability.

rustbot · 2023-03-31T02:44:33Z

r? @WaffleLapkin

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-03-31T02:44:36Z

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

These commits modify the Cargo.lock file. Random changes to Cargo.lock can be introduced when switching branches and rebasing PRs.
This was probably unintentional and should be reverted before this PR is merged.

If this was intentional then you can ignore this comment.

bryangarza · 2023-03-31T02:44:49Z

cc @jswrenn

bryangarza · 2023-03-31T06:53:46Z

I think I missed some tests that need to be blessed, I’ll do it tomorrow

compiler/rustc_transmute/Cargo.toml

tests/ui/transmutability/enums/repr/should_require_well_defined_layout.stderr

tests/ui/transmutability/enums/should_pad_variants.stderr

tests/ui/transmutability/enums/should_respect_endianness.stderr

tests/ui/transmutability/visibility/should_reject_if_dst_has_private_field.stderr

compiler/rustc_transmute_types/Cargo.toml

compiler/rustc_middle/src/traits/mod.rs

compiler-errors · 2023-04-03T21:04:29Z

use @rustbot ready to mark this as ready to review

@rustbot author

rustbot · 2023-04-06T02:24:00Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

compiler/rustc_middle/src/traits/mod.rs

bryangarza · 2023-04-06T02:29:28Z

FYI

easier to review if you hide whitespace changes
Many of the changes in rustc_transmute are just moving some definitions to be under mod rustc

compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs

compiler/rustc_trait_selection/src/traits/select/confirmation.rs

tests/ui/transmutability/arrays/should_require_well_defined_layout.stderr

bryangarza · 2023-04-07T04:04:28Z

@rustbot ready

compiler/rustc_transmute/src/layout/tree.rs

compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs

compiler/rustc_transmute/src/lib.rs

compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs

compiler/rustc_transmute/src/layout/tree.rs

compiler-errors · 2023-04-09T05:41:25Z

Some more comments. Other than those, I'm pretty happy with the state of this PR, though.

@rustbot author

compiler-errors · 2023-04-12T19:08:42Z

r=me after rebasing

there may be some problems with the error reporting with the new trait solver, since we will need to recompute the cannot-transmute-reason on demand in the error reporting code...

you can probably just leave that though, I can figure it out, unless you want to. ping me if you need help.

compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs

compiler-errors · 2023-04-13T21:53:12Z

Thanks @bryangarza for dealing with many rounds of review.

@bors r+

bors · 2023-04-13T21:53:14Z

📌 Commit 6a4b2e89ff25f85507f603a4724f1ddadc16a1c9 has been approved by compiler-errors

It is now in the queue for this repository.

This patch updates the error reporting when Safe Transmute is not possible between 2 types by including the reason. Also, fix some small bugs that occur when computing the `Answer` for transmutability.

bryangarza · 2023-04-13T22:00:23Z

@compiler-errors I force pushed a small change after approval (to get rustc_transmute to successfully pass cargo test) -- is it possible to get this new commit hash to be the one in the queue?

compiler-errors · 2023-04-13T22:01:02Z

Force-pushing automatically un-approves your PR. I will re-approve it when CI is green.

bryangarza · 2023-04-13T22:48:48Z

@rustbot ready

compiler-errors · 2023-04-13T23:05:55Z

@bors r+

bors · 2023-04-13T23:05:57Z

📌 Commit 36febe1 has been approved by compiler-errors

It is now in the queue for this repository.

…-errors, r=compiler-errors Improve safe transmute error reporting This patch updates the error reporting when Safe Transmute is not possible between 2 types by including the reason. Also, fix some small bugs that occur when computing the `Answer` for transmutability.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#109225 (Clarify that RUST_MIN_STACK may be internally cached) - rust-lang#109800 (Improve safe transmute error reporting) - rust-lang#110158 (Remove obsolete test case) - rust-lang#110180 (don't uniquify regions when canonicalizing) - rust-lang#110207 (Assemble `Unpin` candidates specially for generators in new solver) - rust-lang#110276 (Remove all but one of the spans in `BoundRegionKind::BrAnon`) - rust-lang#110279 (rustdoc: Correctly handle built-in compiler proc-macros as proc-macro and not macro) - rust-lang#110298 (Cover edge cases for {f32, f64}.hypot() docs) - rust-lang#110299 (Switch to `EarlyBinder` for `impl_subject` query) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned WaffleLapkin Mar 31, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Mar 31, 2023

bryangarza force-pushed the safe-transmute-improved-errors branch from a1e2b22 to f9b7248 Compare March 31, 2023 02:47

This comment has been minimized.

Sign in to view

compiler-errors self-assigned this Mar 31, 2023

jswrenn requested changes Mar 31, 2023

View reviewed changes

compiler-errors reviewed Mar 31, 2023

View reviewed changes

compiler/rustc_transmute_types/Cargo.toml Outdated Show resolved Hide resolved

compiler/rustc_middle/src/traits/mod.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2023

bryangarza force-pushed the safe-transmute-improved-errors branch from f9b7248 to 2bbb76b Compare April 6, 2023 02:23

bryangarza commented Apr 6, 2023

View reviewed changes

compiler/rustc_middle/src/traits/mod.rs Outdated Show resolved Hide resolved

compiler-errors reviewed Apr 6, 2023

View reviewed changes

bryangarza force-pushed the safe-transmute-improved-errors branch 2 times, most recently from abaa6f6 to 5e2e976 Compare April 7, 2023 04:04

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 7, 2023

compiler-errors reviewed Apr 9, 2023

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2023

compiler-errors approved these changes Apr 12, 2023

View reviewed changes

compiler-errors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2023

bryangarza force-pushed the safe-transmute-improved-errors branch from 5ee760b to 7c49f13 Compare April 12, 2023 22:59

bryangarza commented Apr 12, 2023

View reviewed changes

compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs Outdated Show resolved Hide resolved

bryangarza force-pushed the safe-transmute-improved-errors branch from 7c49f13 to 6a4b2e8 Compare April 13, 2023 21:39

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 13, 2023

Improve safe transmute error reporting

36febe1

This patch updates the error reporting when Safe Transmute is not possible between 2 types by including the reason. Also, fix some small bugs that occur when computing the `Answer` for transmutability.

bryangarza force-pushed the safe-transmute-improved-errors branch from 6a4b2e8 to 36febe1 Compare April 13, 2023 21:57

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 13, 2023

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 13, 2023

matthiaskrgr mentioned this pull request Apr 14, 2023

Rollup of 10 pull requests #110310

Closed

matthiaskrgr mentioned this pull request Apr 14, 2023

Rollup of 9 pull requests #110311

Merged

bors merged commit c6223e1 into rust-lang:master Apr 14, 2023

rustbot added this to the 1.70.0 milestone Apr 14, 2023

matthiaskrgr mentioned this pull request Apr 17, 2023

ICE: Inconsistent rustc_transmute::is_transmutable(...) result, got Yes #110467

Closed

matthiaskrgr mentioned this pull request Apr 29, 2023

ice: Inconsistent rustc_transmute::is_transmutable(...) result, got Yes #110969

Closed

Uh oh!

Conversation

bryangarza commented Mar 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Mar 31, 2023

Uh oh!

rustbot commented Mar 31, 2023

Uh oh!

bryangarza commented Mar 31, 2023

Uh oh!

This comment has been minimized.

bryangarza commented Mar 31, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

compiler-errors commented Apr 3, 2023

Uh oh!

rustbot commented Apr 6, 2023

Uh oh!

Uh oh!

bryangarza commented Apr 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bryangarza commented Apr 7, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

compiler-errors commented Apr 9, 2023

Uh oh!

compiler-errors commented Apr 12, 2023

Uh oh!

Uh oh!

compiler-errors commented Apr 13, 2023

Uh oh!

bors commented Apr 13, 2023

Uh oh!

bryangarza commented Apr 13, 2023

Uh oh!

compiler-errors commented Apr 13, 2023

Uh oh!

bryangarza commented Apr 13, 2023

Uh oh!

compiler-errors commented Apr 13, 2023

Uh oh!

bors commented Apr 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

bryangarza commented Mar 31, 2023 •

edited

Loading

bryangarza commented Apr 6, 2023 •

edited

Loading