Add suggestion to use closure argument instead of a capture on borrowck error#110061
Merged
bors merged 5 commits intorust-lang:masterfrom Apr 20, 2023
Merged
Add suggestion to use closure argument instead of a capture on borrowck error#110061bors merged 5 commits intorust-lang:masterfrom
bors merged 5 commits intorust-lang:masterfrom
Conversation
rustbot
added
S-waiting-on-review
WaffleLapkin
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
WaffleLapkin
added
A-diagnostics
Member
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
rust-cloud-vms
bot
force-pushed
the
duality_of_myself_and_this
branch
from
ea6fc6c to
0c8ebc9
Compare
cjgillot
reviewed
Apr 12, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
|
☔ The latest upstream changes (presumably #110405) made this pull request unmergeable. Please resolve the merge conflicts. |
rust-cloud-vms
bot
force-pushed
the
duality_of_myself_and_this
branch
from
385d50c to
e1b56cb
Compare
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
duality_of_myself_and_this
branch
from
d814747 to
8c4596d
Compare
Collaborator
|
☔ The latest upstream changes (presumably #110458) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
r? @cjgillot |
rust-cloud-vms
bot
force-pushed
the
duality_of_myself_and_this
branch
from
8c4596d to
b47cd78
Compare
Contributor
|
r=me with review commits squashed into main commits |
rust-cloud-vms
bot
force-pushed
the
duality_of_myself_and_this
branch
from
b47cd78 to
4daa932
Compare
rust-cloud-vms
bot
force-pushed
the
duality_of_myself_and_this
branch
from
4daa932 to
5d41a46
Compare
While it might *seem* that this does something, it actually doesn't.
`mut_borrow_of_mutable_ref` returns a `bool` that is ignored by the
let-else. This was basically
```rust
if !self.body.local_decls.get(local).is_some() {
return
}
```
Which is pretty useless
We use caller information to track where a diagnostic was created, so all "helper" diagnostic functions should use `#[track_caller]`
rust-cloud-vms
bot
force-pushed
the
duality_of_myself_and_this
branch
from
5d41a46 to
cac143f
Compare
Member
Author
|
@bors r=cjgillot I've cleaned-up the git history |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (b9fd498): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #109271
r? @compiler-errors
This should probably be refined a bit, but opening a PR so that I don't forget anything.