Split out a separate feature gate for impl trait in associated types#110237
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 12, 2023
Merged
Split out a separate feature gate for impl trait in associated types#110237bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jackh726 (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Member
|
r=me with CI green |
65d3b42 to
28f7646
Compare
28f7646 to
f263f88
Compare
Contributor
Author
|
@bors r=jackh726 |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#110153 (Fix typos in compiler) - rust-lang#110165 (rustdoc: use CSS `overscroll-behavior` instead of JavaScript) - rust-lang#110175 (Symbol cleanups) - rust-lang#110203 (Remove `..` from return type notation) - rust-lang#110205 (rustdoc: make settings radio and checks thicker, less contrast) - rust-lang#110222 (Improve the error message when forwarding a matched fragment to another macro) - rust-lang#110237 (Split out a separate feature gate for impl trait in associated types) - rust-lang#110241 (tidy: Issue an error when UI test limits are too high) Failed merges: - rust-lang#110218 (Remove `ToRegionVid`) r? `@ghost` `@rustbot` modify labels: rollup
AlexTMjugador
added a commit
to ComunidadAylas/PackSquash
that referenced
this pull request
Apr 13, 2023
…assoc_type` This change was introduced by rust-lang/rust#110237 in the latest nightlies.
BlueGlassBlock
added a commit
to BlueGlassBlock/ricq
that referenced
this pull request
Apr 13, 2023
This change was introduced by rust-lang/rust#110237 in the latest nightly.
BlueGlassBlock
added a commit
to BlueGlassBlock/ricq
that referenced
this pull request
Apr 13, 2023
This change was introduced by rust-lang/rust#110237 in the latest nightly.
lz1998
pushed a commit
to lz1998/ricq
that referenced
this pull request
Apr 13, 2023
This change was introduced by rust-lang/rust#110237 in the latest nightly.
Dirbaio
added a commit
to embassy-rs/embassy
that referenced
this pull request
Apr 14, 2023
Includes this TAIT breaking change. rust-lang/rust#110237
Dirbaio
added a commit
to embassy-rs/embassy
that referenced
this pull request
Apr 17, 2023
Includes this TAIT breaking change. rust-lang/rust#110237
Dirbaio
added a commit
to embassy-rs/embassy
that referenced
this pull request
Apr 18, 2023
Includes this TAIT breaking change. rust-lang/rust#110237
46 tasks
10 tasks
overvenus
added a commit
to overvenus/tikv
that referenced
this pull request
Dec 22, 2023
See rust-lang/rust/pull/110237 Signed-off-by: Neil Shen <overvenus@gmail.com>
57 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in #107645 it was decided that we'll take a new route for type alias impl trait. The exact route isn't clear yet, so while I'm working on implementing some of these proposed changes (e.g. in #110010) to be able to experiment with them, I will also work on stabilizing another sugar version first: impl trait in associated types. Similarly I'll look into creating feature gates for impl trait in const/static types.
This PR does nothing but split the feature gate, so that you need to enable a different feature gate for
than what you need for
type Foo = impl SomeTrait;