[compiletest] Add more test ignore reasons, needs- validation, and improved error messages#110319
Merged
bors merged 8 commits intorust-lang:masterfrom Apr 16, 2023
Merged
Conversation
Contributor
|
Nice! Again I have not validated the before/after ignore count, but from a cursory look at all the ignored tests it looks good. @bors r+ |
Collaborator
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This was referenced Apr 16, 2023
Collaborator
|
Finished benchmarking commit (50b816f): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes more improvements to the way compiletest ignoring headers are handled, following up on #108905:
needs-*directives,*llvm*directives, and debugger version directives). All ignored tests should now have a human-readable reason.needs-*directives has been refactored, and now invalidneeds-*directive emit errors likeignore-*andonly-*.This PR is best reviewed commit-by-commit.
r? @ehuss