Merged
Conversation
So that people have to keep them sorted in future.
So that people have to keep them sorted in future, rather than just sticking them on the end where they conflict more often.
and couple of its methods
…uillaumeGomez Stabilize rustdoc `--test-run-directory` This should resolve rust-lang#84674
…14,albertlarsan68 Create "suggested tests" tool in `rustbuild` Not the claimed person in rust-lang#97339 but: I've done a very rough implementation of this feature in-tree. I'm very new to `rustc` development (outside of docs) so some help would be greatly appreciated. The UI of this new subcommand obviously will change and I need some mentoring with the `--run` flag. r? ```@jyn514```
Add link to `collections` docs to `extend` trait I believe it would be useful here.
Add `tidy-alphabetical` to features in `core` So that people have to keep them sorted in future, rather than just sticking them on the end where they conflict more often.
Add `tidy-alphabetical` to features in `alloc` & `std` So that people have to keep them sorted in future, rather than just sticking them on the end where they conflict more often. Follow-up to rust-lang#110269 cc `@jyn514`
…=GuillaumeGomez rustdoc-search: use ES6 `Map` and `Set` where they make sense Since all supported browsers now support these classes, and rustdoc has started using them in some places, it might as well use them everywhere it makes sense (because, as [MDN's Map page] says, it "performs better in scenarios involving frequent additions and removals of key-value pairs."). [MDN's Map page]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map
Add a stable MIR way to get the main function This is useful for analysis tools that only analyze the code paths that a specific program actually goes through. Or for code generators built on top of stable MIR.
rustbot
added
S-waiting-on-review
Member
Author
|
@bors r+ p=7 rollup=never |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: previous master: b0884a3528 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Apr 14, 2023
Collaborator
|
Finished benchmarking commit (660c966): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
--test-run-directory#103682 (Stabilize rustdoc--test-run-directory)rustbuild#106249 (Create "suggested tests" tool inrustbuild)collectionsdocs toextendtrait #110047 (Add link tocollectionsdocs toextendtrait)tidy-alphabeticalto features incore#110269 (Addtidy-alphabeticalto features incore)tidy-alphabeticalto features inalloc&std#110292 (Addtidy-alphabeticalto features inalloc&std)MapandSetwhere they make sense #110305 (rustdoc-search: use ES6MapandSetwhere they make sense)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup