Migrate rustc_hir_analysis to session diagnostic [Part 4]#110325
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 25, 2023
Merged
Migrate rustc_hir_analysis to session diagnostic [Part 4]#110325bors merged 1 commit intorust-lang:masterfrom
rustc_hir_analysis to session diagnostic [Part 4]#110325bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Contributor
|
@rustbot author |
rustbot
added
S-waiting-on-author
obeis
force-pushed
the
hir-analysis-migrate-diagnostics-4
branch
from
f2b469c to
3bc3aae
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
This comment was marked as resolved.
This comment was marked as resolved.
Part 4: Finishing `check/mod.rs` file
obeis
force-pushed
the
hir-analysis-migrate-diagnostics-4
branch
from
3bc3aae to
06ff310
Compare
davidtwco
approved these changes
Apr 24, 2023
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 24, 2023
…tics-4, r=davidtwco Migrate `rustc_hir_analysis` to session diagnostic [Part 4] Part 4: Finishing `check/mod.rs` file r? `@compiler-errors`
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (a7aa205): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 4: Finishing
check/mod.rsfiler? @compiler-errors