fix(resolve): only disambiguate binding key during define

[bvanjoi]

• close ICE: stack overflow in resolver #110164
• discussion: fix(resolve): prevent infinite loop when glob-import self #110264 (comment)

r? @petrochenkov

[petrochenkov]

Thanks!
r=me after cleaning up formatting (#110493 (comment)).
@rustbot author

[petrochenkov]

@bors r+

[bors]

📌 Commit 2983f2f4a8a2bd56be514105096fe90ace5fa93d has been approved by petrochenkov

It is now in the queue for this repository.

[bvanjoi]

It may be necessary to approve again, probably because the subsequent push --force has left the queue in an unapproved state @petrochenkov

[bors]

☔ The latest upstream changes (presumably #110852) made this pull request unmergeable. Please resolve the merge conflicts.

[bvanjoi]

Clearing git conflicts completed, @rustbot ready

[wesleywiser]

Manually reviewed the diffs and the code changes are the same as when @petrochenkov originally reviewed modulo fixes to use statements during rebase.

@bors r=petrochenkov

[bors]

📌 Commit 5b09810 has been approved by petrochenkov

It is now in the queue for this repository.

[bors]

⌛ Testing commit 5b09810 with merge d3f416d...

[bors]

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing d3f416d to master...

[rust-timer]

Finished benchmarking commit (d3f416d): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.5%	[1.5%, 1.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.4%	[1.4%, 1.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 641s -> 640.647s (-0.06%)