Make method-not-found-generic-arg-elision.rs error message not path dependent#110866
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 27, 2023
Merged
Make method-not-found-generic-arg-elision.rs error message not path dependent#110866bors merged 1 commit intorust-lang:masterfrom
method-not-found-generic-arg-elision.rs error message not path dependent#110866bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Member
jyn514
added
the
A-testsuite
Contributor
Author
|
@jyn514: this is the only one that affecting me, probably due to the fact that it's a closure + Map combinator + vec::Iter. I bet if I moved my rustc into an even deeper subdirectory, more would trigger. I'm somewhat selfishly putting this one up just to fix the one that's been affecting my productivity, but thanks for linking to alternative solution PRs, I'll give those a read. |
Member
|
@bors r+ rollup we can fix this for other tests as they cause issues, this seems like a strict improvement |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 27, 2023
Make `method-not-found-generic-arg-elision.rs` error message not path dependent Every time I bless `tests/ui/methods/method-not-found-generic-arg-elision.rs`, I get some nonsense "type is too long" + "written to disk" that shows up and have to manually revert because the combination of my rustc repo path + the UI test directory hits the length limit for printing types spilling to disk (since this happens before UI test path sanitization). The fact that we use a closure in this test doesn't have to do with the UI test, so just box the closure to make the type name smaller and not path dependent.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#110426 (docs(style): add more let-else examples) - rust-lang#110804 (Remove repeated definite articles) - rust-lang#110814 (Sprinkle some `#[inline]` in `rustc_data_structures::tagged_ptr`) - rust-lang#110816 (Migrate `rustc_passes` to translatable diagnostics) - rust-lang#110864 (`IntoFuture::into_future` is no longer unstable) - rust-lang#110866 (Make `method-not-found-generic-arg-elision.rs` error message not path dependent) - rust-lang#110872 (Nicer ICE for rust-lang#67981) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every time I bless
tests/ui/methods/method-not-found-generic-arg-elision.rs, I get some nonsense "type is too long" + "written to disk" that shows up and have to manually revert because the combination of my rustc repo path + the UI test directory hits the length limit for printing types spilling to disk (since this happens before UI test path sanitization).The fact that we use a closure in this test doesn't have to do with the UI test, so just box the closure to make the type name smaller and not path dependent.