[watchos] Fix broken target arm64_32-apple-watchos#111267
[watchos] Fix broken target arm64_32-apple-watchos#111267vladimir-ea wants to merge 1 commit intorust-lang:masterfrom
Conversation
|
(rustbot has picked a reviewer for you, use r? to override) |
|
Are we sure that this is the right fix? To my understanding, watchOS is an AArch64-ILP32 target. The PR adding it to LLVM certainly thinks so. |
|
The 'proper' fix is here: gimli-rs/object#542. This is a workaround to revert to the previous behaviour, but I guess the previous behaviour was wrong, although it did 'work' (in the sense that it was possible to build and run rust libraries for arm64_32-apple-watchos). Mybe I should close this Pr and wait for the 'object' change? |
|
I don't think it would be invalid to choose to revert to the previous behavior. Partly because it's not required that the target work, so switching from busted (doesn't compile) to busted (compiles at all, but might miscompile a random program) is permitted, strictly speaking. This does imply there's also no mandate to get this target up and running immediately, and we know that both behaviors we can choose from without updating Which also means that if you do want to land this, then as far as I am concerned, by all means. |
|
Not sure if I have a strong opinion about this, so |
|
Closing this since the fix to 'object' has been released. See: #111413 |
Issue #111217