Propagate recursion depth in collect_predicates_for_types

[matthewjasper]

This only changes the Obligation::new call that caused the linked issue, but there are some others in the trait solver that should be looked at later.

Bug was introduced in #109119, so fix might be worth backporting.
cc #111729

r? @lcnr

[lcnr]

This only changes the Obligation::new call that caused the linked issue, but there are some others in the trait solver that should be looked at later.

I think that generally, relying on Obligation::with_depth to get this right is very dangerous. There are a lot of places where we either use obligation.rebind or just Obligation::new.

Looked for a safer approach to correctly updating the depth here which resulted in #111754. I hope you don't mind me opening a separate PR here, I already made the change to test that it works so just dropping that change and suggesting it in a review didn't feel useful.

[apiraino]

I'll un-nominate for backport since superseded by #111754

@rustbot label -beta-nominated