Rename {drop,forget}_{copy,ref} lints to more consistent naming#111756
Merged
bors merged 4 commits intorust-lang:masterfrom May 22, 2023
Merged
Rename {drop,forget}_{copy,ref} lints to more consistent naming#111756bors merged 4 commits intorust-lang:masterfrom
{drop,forget}_{copy,ref} lints to more consistent naming#111756bors merged 4 commits intorust-lang:masterfrom
Conversation
Collaborator
|
r? @eholk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Collaborator
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy The Miri subtree was changed cc @rust-lang/miri |
Collaborator
|
☔ The latest upstream changes (presumably #111799) made this pull request unmergeable. Please resolve the merge conflicts. |
Urgau
force-pushed
the
rename_drop_forget_copy_ref_lints
branch
from
d74decb to
6b08a74
Compare
fee1-dead
approved these changes
May 22, 2023
Member
fee1-dead
left a comment
fee1-dead
left a comment
There was a problem hiding this comment.
It might be better to merge these four into a single one, since they are pretty similar and I don't think a user necessarily needs to allow/disallow individual ones.
Member
|
r? @fee1-dead @bors r+ |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 22, 2023
Rollup of 6 pull requests Successful merges: - rust-lang#111501 (MIR drive-by cleanups) - rust-lang#111609 (Mark internal functions and traits unsafe to reflect preconditions) - rust-lang#111612 (Give better error when collecting into `&[T]`) - rust-lang#111756 (Rename `{drop,forget}_{copy,ref}` lints to more consistent naming) - rust-lang#111843 (move lcnr to only review types stuff) - rust-lang#111844 (Migrate GUI colors test to original CSS color format) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames previous uplifted lints in #109732 to more consistent naming.
I followed the renaming done here and also advocated in this clippy issue:
drop_copytodropping_copy_typesforget_copytoforgetting_copy_typesdrop_reftodropping_referencesforget_reftoforgetting_references