Rollup of 4 pull requests#112470
Closed
GuillaumeGomez wants to merge 11 commits intorust-lang:masterfrom
Closed
Conversation
Previously it removed all other attributes from the crate root. Now it removes only attributes below itself. So it becomes possible to configure some global crate properties even for fully unconfigured crates.
be more explicit in where we only add new hidden types and where we also have to deal with item bounds.
… directly alongside the expected values
…pkin expand: Change how `#![cfg(FALSE)]` behaves on crate root Previously it removed all other attributes from the crate root. Now it removes only attributes below itself (during both regular expansion and pre-configuration). So it becomes possible to configure some global crate properties even for fully unconfigured crates. Fixes rust-lang#104633 Part of rust-lang#110082
…chenkov Make "consider importing" consistent for macros Fixes rust-lang#112439
…er-errors opaque type cleanup the commits are pretty self-contained. r? `@compiler-errors` cc `@oli-obk`
…ormats, r=notriddle Change format of rustdoc-js tests by putting query and correction directly alongside the expected values As I was working on fixing merge conflicts in rust-lang#108537, I faced quite a big issue when trying to update the `rustdoc-js*` tests. To make it much simpler, this PR moves the `query` and `correction` directly alongside the expected data so now we know what is the query that is being run without needing to add comments or going back to the top of the file. r? `@notriddle`
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
#![cfg(FALSE)]behaves on crate root #110141 (expand: Change how#![cfg(FALSE)]behaves on crate root)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup