Dummy PR to test coverage test changes in CI#112514
Dummy PR to test coverage test changes in CI#112514Zalathar wants to merge 1 commit intorust-lang:masterfrom
Conversation
|
As I suspected, The run-make tests couldn't express this restriction, but with run-coverage I can just add an |
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #112418) made this pull request unmergeable. Please resolve the merge conflicts. |
|
New experiment: I've been assuming that |
|
Unexpectedly, those tests now seem to pass on Linux as well: https://github.com/rust-lang/rust/actions/runs/5275751902/jobs/9541593530?pr=112514 |
|
Next experiment: Check whether This will tell me whether the failure has been magically fixed by someone else, or whether it has been magically fixed by my migration. |
|
For reference, I last saw these tests fail on Linux in #111179 (comment) . |
|
Per https://github.com/rust-lang/rust/actions/runs/5276267731/jobs/9542755469?pr=112514 , the test seems to succeed on Linux even on current master, without my migration to run-coverage. |
|
I'll do another test run on Linux (this time with no changes to bootstrap), just for good measure. |
7012112 to
a6b41de
Compare
|
Now that I've said #112300 is ready to merge, I want to run one last cross-platform check to make sure that nothing has mysteriously broken over the last few weeks. |
|
☔ The latest upstream changes (presumably #113105) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #114148) made this pull request unmergeable. Please resolve the merge conflicts. |
I have some changes to the coverage tests (#112300) that need to be tested on other platforms to make sure they don't break anything.
r? @ghost