Skip to content

resolve: Update glob bindings in case of ambiguities (non-recursively)#113240

Closed
petrochenkov wants to merge 1 commit intorust-lang:masterfrom
petrochenkov:impambig2
Closed

resolve: Update glob bindings in case of ambiguities (non-recursively)#113240
petrochenkov wants to merge 1 commit intorust-lang:masterfrom
petrochenkov:impambig2

Conversation

@petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Jul 1, 2023 •
edited
Loading

One independent subset of #112743 for a mini crater run.
cc @bvanjoi

TODO: @craterbot check p=1 crates=https://crater-reports.s3.amazonaws.com/pr-112743/retry-regressed-list.txt

@rustbot
Copy link
Collaborator

rustbot commented Jul 1, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 1, 2023
@petrochenkov
Copy link
Contributor Author

petrochenkov commented Jul 1, 2023

@bors try

@bors
Copy link
Collaborator

bors commented Jul 1, 2023

⌛ Trying commit ef2ebf4 with merge 377afada703be70d3fdff9164a481570a3cba7fe...

@petrochenkov petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2023
bvanjoi
bvanjoi reviewed Jul 1, 2023
View reviewed changes
compiler/rustc_resolve/src/imports.rs
// We are glob-importing the same item but with greater visibility.
resolution.binding = Some(binding);
} else if binding.is_ambiguity() {
resolution.binding = Some(binding);
Copy link
Contributor

@bvanjoi bvanjoi Jul 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it solve #112713? I'm not sure.

@petrochenkov petrochenkov mentioned this pull request Jul 1, 2023
Closed
@bors
Copy link
Collaborator

bors commented Jul 1, 2023

☀️ Try build successful - checks-actions
Build commit: 377afada703be70d3fdff9164a481570a3cba7fe (377afada703be70d3fdff9164a481570a3cba7fe)

@petrochenkov
Copy link
Contributor Author

petrochenkov commented Jul 1, 2023

@craterbot check p=1 crates=https://crater-reports.s3.amazonaws.com/pr-112743/retry-regressed-list.txt

@craterbot
Copy link
Collaborator

craterbot commented Jul 1, 2023

🚨 Error: missing desired crates: {"cloudflare-r2"}

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@petrochenkov
Copy link
Contributor Author

petrochenkov commented Jul 1, 2023

@craterbot check p=1 crates=https://gist.githubusercontent.com/petrochenkov/78c5487fedf991fad040ff42a8a36e69/raw/cc4e227ef0fe8d65cc5d107ed84847d7b6bd5a94/gistfile1.txt

@craterbot
Copy link
Collaborator

craterbot commented Jul 1, 2023

👌 Experiment pr-113240 created and queued.
🤖 Automatically detected try build 377afada703be70d3fdff9164a481570a3cba7fe
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

craterbot commented Jul 2, 2023

🚧 Experiment pr-113240 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

craterbot commented Jul 2, 2023

🎉 Experiment pr-113240 is completed!
📊 0 regressed and 0 fixed (8908 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jul 2, 2023
@petrochenkov petrochenkov mentioned this pull request Jul 3, 2023
Merged
@petrochenkov petrochenkov deleted the impambig2 branch February 22, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bvanjoi bvanjoi bvanjoi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@davidtwco davidtwco

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@petrochenkov @rustbot @bors @craterbot @bvanjoi @davidtwco