don't ICE on higher ranked hidden types

[aliemjay]

This shouldn't allow more code to compile, only replaces the ICE with a nicer error message.

Fixes #97098.
Fixes #97099.
Fixes #108399
Fixes #104196
Fixes #113481
Fixes #103186
Fixes #100818

r? @lcnr (because you showed interest in #100503 :)

[compiler-errors]

ci is broken for unrelated reasons 😓

[lcnr]

r=me after rebase

[lcnr]

two thoughts:

• the bool is unused by the only caller, can change the return type to ().
• can you add a comment that this only adds the member constraints to the region graph and that we don't check them here but instead in check_member_constraints after the region graph has been computed?

[oli-obk]

I rebased, blessed and addressed the review comment

@bors r=lcnr

[bors]

📌 Commit d55522a has been approved by lcnr

It is now in the queue for this repository.

[bors]

⌛ Testing commit d55522a with merge 03181e0...

[bors]

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 03181e0 to master...

[rust-timer]

Finished benchmarking commit (03181e0): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.5%	[-0.5%, -0.5%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.4%, 2.6%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.5%	[-1.6%, -1.4%]	2
All ❌✅ (primary)	1.9%	[1.4%, 2.6%]	3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 649.353s -> 649.27s (-0.01%)