Remap paths for ~/.cargo in UI tests#113611
Closed
jyn514 wants to merge 2 commits intorust-lang:masterfrom
Closed
Conversation
Collaborator
|
r? @ozkanonur (rustbot has picked a reviewer for you, use r? to override) |
Member
Author
|
oh, apparently the reason i didn't notice this earlier is because sources were broken for foreign crates until recently lol #111146 |
onur-ozkan
reviewed
Jul 12, 2023
Contributor
|
@bors r+ rollup |
Collaborator
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 12, 2023
…=ozkanonur Remap paths for ~/.cargo in UI tests Users won't have the original cargo registry from the CI builder available, even if they have `rust-src` installed. Don't show their sources in UI tests even if they're available. As a happy side-effect, this fixes a few UI tests when download-rustc is enabled. Helps with rust-lang#112143.
Member
|
@bors r- rollup=iffy |
This comment has been minimized.
This comment has been minimized.
mati865
reviewed
Jul 15, 2023
This comment has been minimized.
This comment has been minimized.
6e84f62 to
cde05ee
Compare
Member
Author
|
@bors r=ozkanonur |
Collaborator
Collaborator
|
⌛ Testing commit cde05ee with merge 41031f1f347df1df8619fd30d17fd832ce09c17b... |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
💔 Test failed - checks-actions |
Member
Author
|
I don't understand this failure. It doesn't replicate locally on Linux - I can try in a bit with an apple machine. The debuginfo it expects to be present isn't related to ~/.cargo: so I am not quite sure what could be going wrong here. |
Member
Author
This was referenced Nov 12, 2023
Users won't have the original cargo registry from the CI builder available, even if they have `rust-src` installed. Don't show their sources in UI tests even if they're available. As a happy side-effect, this fixes a few UI tests when download-rustc is enabled.
cde05ee to
ae44ad5
Compare
Member
Author
|
oh, this was done as part of #115869 |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users won't have the original cargo registry from the CI builder available, even if they have
rust-srcinstalled. Don't show their sources in UI tests even if they're available. As a happy side-effect, this fixes a few UI tests when download-rustc is enabled.Helps with #112143.