Merged
Conversation
rustbot
added
S-waiting-on-review
onur-ozkan
approved these changes
Jul 13, 2023
Contributor
onur-ozkan
left a comment
onur-ozkan
left a comment
There was a problem hiding this comment.
This PR alone reduces a lot of confusion. Thanks a lot! :)
Only 1 suggestion which is non-blocker. Feel free to queue this up with r=me if you don't agree on the suggestion.
Member
Author
|
@bors r=ozkanonur |
Collaborator
|
📌 Commit e99d99a7eec7431d4c1984cd93a0ad32283fa2ab has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit e99d99a7eec7431d4c1984cd93a0ad32283fa2ab with merge f295a360b0630b5c1d5735d6904e24390dafd3db... |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Member
Author
bors
added
S-waiting-on-bors
Collaborator
|
☔ The latest upstream changes (presumably #113514) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
This does three things: 1. Remove `forward!(Build, fn try_run())`. Having `try_run` behave differently as a free function than an associated function is confusing, and `Builder::try_run` is a very desirable name. 2. Move `test::try_run` and `run::try_run` to `Builder::try_run`. These functions are different than `Config::try_run` - they delay the failure and print it out at the end of the build. 3. Mark `Config::try_run` as deprecated to encourage people to use `Builder::try_run` instead.
It was only used when a `builder` is available, and I want to encourage using the version that supports `--no-fail-fast`.
Member
Author
|
@bors r=ozkanonur |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 16, 2023
Rollup of 3 pull requests Successful merges: - rust-lang#113643 (bootstrap: Clean up try_run) - rust-lang#113731 (Remove unused `bootstrap::util::CiEnv` enum) - rust-lang#113737 (update mailmap for myself) r? `@ghost` `@rustbot` modify labels: rollup
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @ozkanonur since you reviewed @GuillaumeGomez's PR
i recommend reviewing commit-by-commit