Add regression test for echo 'mod unknown;' | rustc -#114093
Merged
bors merged 2 commits intorust-lang:masterfrom Aug 7, 2023
Merged
Add regression test for echo 'mod unknown;' | rustc -#114093bors merged 2 commits intorust-lang:masterfrom
echo 'mod unknown;' | rustc -#114093bors merged 2 commits intorust-lang:masterfrom
Conversation
Collaborator
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Enselic
force-pushed
the
stdin-unknown-mod
branch
from
adba30e to
86433e6
Compare
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 31, 2023
…Simulacrum Add regression test for `echo 'mod unknown;' | rustc -` Closes rust-lang#65601 The bug is fixed since long ago, probably by rust-lang#69838 (see rust-lang#65601 (comment) for more details). Add a regression test so we can close the issue.
Member
bors
added
S-waiting-on-author
The test fails on Windows with the diff
- = help: to create the module `unknown`, create file "unknown.rs" or "unknown/mod.rs"
+ = help: to create the module `unknown`, create file "unknown.rs" or "unknown\mod.rs"
There is no need to run this test on Windows, so ignore it.
Member
Author
|
The test fails because of this diff: There is no need to run this test on Windows, so let's just not. I have now added @rustbot ready |
rustbot
added
S-waiting-on-review
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 7, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#98935 (Implement `Option::take_if`) - rust-lang#114093 (Add regression test for `echo 'mod unknown;' | rustc -`) - rust-lang#114229 (Nest tests/codegen/sanitizer*.rs tests in sanitizer dir) - rust-lang#114230 (Nest other codegen test topics) - rust-lang#114362 (string.rs: remove "Basic usage" text) - rust-lang#114365 (str.rs: remove "Basic usage" text) - rust-lang#114382 (Add a new `compare_bytes` intrinsic instead of calling `memcmp` directly) - rust-lang#114549 (Style fix and refactor on resolve diagnostics) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #65601
The bug is fixed since long ago, probably by #69838 (see #65601 (comment) for more details).
Add a regression test so we can close the issue.