refactor builtin unsize handling, extend comments#114169
Merged
bors merged 2 commits intorust-lang:masterfrom Jul 31, 2023
Merged
refactor builtin unsize handling, extend comments#114169bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
rustbot
added
T-compiler
Collaborator
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
compiler-errors
approved these changes
Jul 28, 2023
Comment on lines
+526
to
+529
| a_data: &'tcx ty::List<ty::PolyExistentialPredicate<'tcx>>, | ||
| a_region: ty::Region<'tcx>, | ||
| b_data: &'tcx ty::List<ty::PolyExistentialPredicate<'tcx>>, | ||
| b_region: ty::Region<'tcx>, |
Contributor
There was a problem hiding this comment.
I don't think it costs very much to just destructure ty::Dynamic again and bug!() here instead of passing this data, but I guess it's ok 😅
That is, I'd rather just pass all the data once (in the goal) rather than both as one package (the goal) + partially destructured (a/b data)
Comment on lines
+610
to
+611
| b_data: &'tcx ty::List<ty::PolyExistentialPredicate<'tcx>>, | ||
| b_region: ty::Region<'tcx>, |
compiler-errors
added
S-waiting-on-author
Contributor
Author
|
@bors r=compiler-errors rollup I see where you're coming from but also dislike having to |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 31, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#114111 (Improve test case for experimental API remove_matches) - rust-lang#114169 (refactor builtin unsize handling, extend comments) - rust-lang#114182 (clean up after 113312) - rust-lang#114193 (Update lexer emoji diagnostics to Unicode 15.0) - rust-lang#114200 (Detect trait upcasting through struct tail unsizing in new solver select) - rust-lang#114228 (Check lazy type aliases for well-formedness) - rust-lang#114267 (Map RPITIT's opaque type bounds back from projections to opaques) - rust-lang#114269 (Migrate GUI colors test to original CSS color format) - rust-lang#114286 (Add missing feature gate in multiple_supertrait_upcastable doc) r? `@ghost` `@rustbot` modify labels: rollup
Contributor
|
While working on #114209 i noticed that |
Contributor
Author
|
the changes are non-functional so I think it should still be in sync, but I did not think about this explicitly so I am going to take another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @compiler-errors