Implement From<&'a &'static str> for Arguments<'a>#114531
Implement From<&'a &'static str> for Arguments<'a>#114531EFanZh wants to merge 1 commit intorust-lang:masterfrom
From<&'a &'static str> for Arguments<'a>#114531Conversation
|
(rustbot has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
99620b3 to
153c2e4
Compare
dtolnay
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Based on rust-lang/libs-team#257 (comment), I believe this is currently blocked while we work to figure out whether #115129 is going to be landable.
|
☔ The latest upstream changes (presumably #125443) made this pull request unmergeable. Please resolve the merge conflicts. |
|
The PR this was blocked on, is now closed due to inactivity, which should unblock this pr, so updating the labels |
|
@EFanZh |
|
@alex-semenyuk: The original ACP suggests that we can add an |
|
@EFanZh any updates on this? Looks like this has hit a roadblock and closing it for now until a new process is thought of might be the best idea but idk if there's any other progress in the meanwhile so checking in |
|
Closed for now. |
|
We now have a new implementation of fmt::Arguments that allows for conversion directly from &str. #148906 exposes fmt::Arguments::from_str() as unstable. Tracking issue: #148905 |
Provides a way to construct an
Argumentsobject from an&'static strobject, and callingas_stron the result object will returnSome(&'static str).ACP: rust-lang/lib-team#257.