Remove conditional use of Sharded from query state

[Zoxc]

Sharded is already a zero cost abstraction, so it shouldn't affect the performance of the single thread compiler if LLVM does its job.

r? @cjgillot

[cjgillot]

@bors try @rust-timer queue

[bors]

⌛ Trying commit b710c3510f927568405dfc4e5c097b1e7d47af80 with merge ebe89831ca8f1fa832d937386b05f63e625b36cb...

[bors]

☀️ Try build successful - checks-actions
Build commit: ebe89831ca8f1fa832d937386b05f63e625b36cb (ebe89831ca8f1fa832d937386b05f63e625b36cb)

[rust-timer]

Finished benchmarking commit (ebe89831ca8f1fa832d937386b05f63e625b36cb): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.5%, 0.6%]	8
Regressions ❌ (secondary)	0.5%	[0.4%, 0.8%]	9
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.5%, 0.6%]	8

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.2%	[1.2%, 1.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 635.223s -> 635.777s (0.09%)
Artifact size: 346.78 MiB -> 347.39 MiB (0.17%)

[Zoxc]

This is now based on top of #114860 and also includes optimizations to lock_sharded. Another perf run would be useful to see if that's the source of the regressions.

[SparrowLii]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 0288e32ac1ad484c903eb967dcad2d76c6e4fe2e with merge 07772aad8312d782e9a2fd15045f4b40d4eae41c...

[bors]

☀️ Try build successful - checks-actions
Build commit: 07772aad8312d782e9a2fd15045f4b40d4eae41c (07772aad8312d782e9a2fd15045f4b40d4eae41c)

[rust-timer]

Finished benchmarking commit (07772aad8312d782e9a2fd15045f4b40d4eae41c): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.5%]	1
Regressions ❌ (secondary)	0.6%	[0.6%, 0.6%]	3
Improvements ✅ (primary)	-0.6%	[-0.6%, -0.5%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-0.6%, 0.5%]	4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.6%	[2.0%, 3.6%]	3
Improvements ✅ (primary)	-3.2%	[-3.2%, -3.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.2%	[-3.2%, -3.2%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 634.954s -> 632.144s (-0.44%)
Artifact size: 347.10 MiB -> 346.39 MiB (-0.20%)

[cjgillot]

The perf effect on the last run balances small improvements and with small regressions.
The simplifications make this PR worth merging.
r=me after rebase

[Zoxc]

Rebased.

[SparrowLii]

@bors r=cjgillot

[bors]

📌 Commit f458b11 has been approved by cjgillot

It is now in the queue for this repository.

[bors]

⌛ Testing commit f458b11 with merge 6d32b29...

[bors]

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 6d32b29 to master...

[rust-timer]

Finished benchmarking commit (6d32b29): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.7%	[-3.7%, -3.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.7%	[-3.7%, -3.7%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 630.165s -> 630.483s (0.05%)
Artifact size: 316.28 MiB -> 316.05 MiB (-0.07%)